Add optional SOPS decryption for HelmRelease values#1475
Closed
SebTardif wants to merge 2 commits intofluxcd:mainfrom
Closed
Add optional SOPS decryption for HelmRelease values#1475SebTardif wants to merge 2 commits intofluxcd:mainfrom
SebTardif wants to merge 2 commits intofluxcd:mainfrom
Conversation
Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca> Assisted-by: GitHub Copilot/GPT-5 mini
Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca> Assisted-by: GitHub Copilot/GPT-5 mini
Member
|
In Flux, kustomize-controller is responsible for decrypting the HelmRelease values. What’s in this PR can not happen as it breaks Flux security model. Such a major change requires an RFC sponsored by a core maintainer. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End goal
This PR contributes to closing fluxcd/flux2#4075: "HelmRelease should support SOPS encryption directly".
The target user outcome is that SOPS-encrypted HelmRelease values can be used without forcing users to split YAMLs or move secrets into separate formats just to satisfy schema validation/workarounds.
What this PR does (scope)
This PR implements the helm-controller side of that goal:
spec.decryptionto HelmRelease APIIn short: this PR is the runtime/controller capability needed for HelmRelease value decryption.
Relation to other repos / dependency clarification
There is related work in flux CLI: fluxcd/flux2#5869, including maintainer feedback in this comment about an opt-in
--strip-sops-metadataflag.That flux2 change improves CLI UX (notably
flux diff) for manifests containing SOPS metadata. This PR is complementary but addresses a different layer.Current PR status
Keeping this PR as draft while review feedback is incorporated.