Migrate event recorder to fluxcd/pkg/runtime/events.Recorder#1038
Draft
adri1197 wants to merge 1 commit into
Draft
Migrate event recorder to fluxcd/pkg/runtime/events.Recorder#1038adri1197 wants to merge 1 commit into
adri1197 wants to merge 1 commit into
Conversation
15 tasks
Member
|
Looks like we can do this here in this controller because it does not use |
Contributor
Author
Correct — this controller only uses Eventf, so the migration is a direct swap 😃. |
matheuscscp
reviewed
Jun 4, 2026
Member
|
@adri1197 CI is failing, PTAL 🙏 |
Contributor
Author
Unfortunately, we may have to wait till kubernetes-sigs/controller-runtime#3509 and therefore the upstream k8s MR, in order to merge fluxcd/pkg#1144, which includes |
Replace the local eventLogf helper with the fluxcd/pkg/runtime/events EventRecorder interface. This removes redundant logging (the recorder handles it internally) and aligns with the pattern used by other Flux controllers. Populate the GitRepository as the related object in all emitted events, enabling notification-controller to correlate automation events with their source. Bump event API from v1beta1 to v1. Replace k8s.io/utils/pointer with builtin new(). Clean up import grouping in main.go. Signed-off-by: Adrian Fernandez De La Torre <adri1197@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes fluxcd/flux2#5761