fix: stabilize changed template data#1043
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Sort aggregated change data before rendering templates so Change-Id\nstyle templates stay stable for the same logical update set.\n\nAdd regression coverage for deterministic change aggregation and\nrepeated template rendering. Signed-off-by: immanuwell <pchpr.00@list.ru> Assisted-by: Codex/GPT-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
.Changed.Changesand the Change-Id style template data stable for the same logical update set.Before this, the aggregation path walked nested maps, so the rendered change data could come out in a different order between runs. That can change commit messages and Gerrit Change-Ids for the same update set. Kinda flaky, not great.
Repro:
messageTemplatethat hashes.Changed.FileChanges,.Changed.Objects, and.Changed.Changes..Changed.Changescan come out in different orders, and aggregated object changes can shuffle too.Related: #771
Context: #925