fix: clear Result when Reconcile returns an error

Both ImageRepositoryReconciler.Reconcile and
ImagePolicyReconciler.Reconcile wrap the subreconciler with a named
return form that always emits both values:

    result, retErr = r.reconcile(ctx, ...)
    return

controller-runtime emits a warning when a Reconcile call returns both
a non-zero Result and a non-nil error — the Result is ignored in that
case and the object is re-queued with the error's exponential backoff.
Populating a RequeueAfter and then returning an error gives the
misleading impression that the caller's requested interval applies.

Drop the Result when there is an error so controller-runtime sees
("", retErr) and the warning no longer fires.

Fixes #661

Signed-off-by: Ali <alliasgher123@gmail.com>

Author: alliasgher

internal/controller/imagepolicy_controller.go

@@ -241,6 +241,12 @@ func (r *ImagePolicyReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 
 	// Call subreconciler.
 	result, retErr = r.reconcile(ctx, serialPatcher, obj)
+	// controller-runtime logs a warning when a Reconcile call returns both
+	// a non-zero Result and a non-nil error; the Result is ignored in that
+	// case. Drop the Result when we have an error to keep the log clean.
+	if retErr != nil {
+		result = ctrl.Result{}
+	}
 	return
 }
 

internal/controller/imagerepository_controller.go

@@ -193,6 +193,12 @@ func (r *ImageRepositoryReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 
 	// Call subreconciler.
 	result, retErr = r.reconcile(ctx, serialPatcher, obj, start)
+	// controller-runtime logs a warning when a Reconcile call returns both
+	// a non-zero Result and a non-nil error; the Result is ignored in that
+	// case. Drop the Result when we have an error to keep the log clean.
+	if retErr != nil {
+		result = ctrl.Result{}
+	}
 	return
 }