Upgrade to Badger v4#816
Merged
Merged
Conversation
Signed-off-by: leigh capili <leigh@null.net>
Signed-off-by: leigh capili <leigh@null.net>
matheuscscp
approved these changes
Sep 10, 2025
|
|
||
| if badgerGC != nil { | ||
| mgr.Add(badgerGC) | ||
| err := mgr.Add(badgerGC) |
Member
There was a problem hiding this comment.
Wow I didn't know you could add runnable things to controller-runtime's Manager :o
Member
Author
There was a problem hiding this comment.
yeah, the first try at the GC was a mess of signal handlers and channels -- was delighted to find this 😮💨
stefanprodan
approved these changes
Sep 10, 2025
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @stealthybox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits:
badger v3.x -> v4.0 isn't a breaking change,
just an update from calver to semver
(no binary format change)
https://github.com/hypermodeinc/badger/blob/main/CHANGELOG.md#400---2023-02-27
The v4.x series does contain 2 breaking changes:
badger uses the go expvar format.
We enable these on our Badger by default, but we don't actually expose them in controller-runtime Prometheus format...
no impact
investigated this: our dependency on their error types for the GC is covered in a test and it's still functioning + unchanged)
Loadtest also rebased and good: #763 (comment)
Closes: #811