Fix ObservedExclusionList doc-comment field reference#918
Open
Socialpranker wants to merge 1 commit into
Open
Conversation
The doc-comment referenced spec.lastScanResult, but LastScanResult lives on ImageRepositoryStatus, not the spec. Fixed in both api/v1 and api/v1beta2, and regenerated the CRD. Assisted-by: Claude Code/claude-sonnet-5 Signed-off-by: Socialpranker <273312799+Socialpranker@users.noreply.github.com>
Member
|
Same problem as fluxcd/source-controller#2109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of fluxcd/flux2#5941 (item 2) — the
ObservedExclusionListfield's doc-comment referencedspec.lastScanResult, butLastScanResultis astatusfield (status.lastScanResult), not part of the spec. Fixed in bothapi/v1andapi/v1beta2, and regenerated the CRD viamake manifests.Cosmetic/documentation only — no functional or behavioral change.
Test plan
go build ./...andcd api && go build ./...— clean.gofmt -lon changed files — no output (already formatted).go vetin theapisubmodule — clean.make manifestsregeneratedconfig/crd/bases/image.toolkit.fluxcd.io_imagerepositories.yaml; diff confirmed to be exactly the one corrected description string, nothing else changed.