Skip to content

Commit 5be0d2b

Browse files
committed
Remove TLS ServerName pinning in TLS config creation
Updates pkg/runtime dependency to v0.80.0 which removes the need for the insecure parameter in TLSConfigFromSecretRef. This change removes the forced ServerName pinning behavior that was causing TLS verification issues, allowing for more flexible certificate validation. The TLS config creation now relies on the standard Go TLS verification process without forcing specific ServerName values, improving compatibility with various certificate configurations. Signed-off-by: cappyzawa <cappyzawa@gmail.com>
1 parent 81c25cf commit 5be0d2b

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ require (
2323
github.com/fluxcd/pkg/cache v0.10.0
2424
github.com/fluxcd/pkg/git v0.34.0
2525
github.com/fluxcd/pkg/masktoken v0.7.0
26-
github.com/fluxcd/pkg/runtime v0.75.0
26+
github.com/fluxcd/pkg/runtime v0.80.0
2727
github.com/fluxcd/pkg/ssa v0.51.0
2828
github.com/fluxcd/pkg/ssh v0.20.0
2929
github.com/getsentry/sentry-go v0.34.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ github.com/fluxcd/pkg/git v0.34.0 h1:qTViWkfpEDnjzySyKRKliqUeGj/DznqlkmPhaDNIsFY
146146
github.com/fluxcd/pkg/git v0.34.0/go.mod h1:F9Asm3MlLW4uZx3FF92+bqho+oktdMdnTn/QmXe56NE=
147147
github.com/fluxcd/pkg/masktoken v0.7.0 h1:pitmyOg2pUVdW+nn2Lk/xqm2TaA08uxvOC0ns3sz6bM=
148148
github.com/fluxcd/pkg/masktoken v0.7.0/go.mod h1:Lc1uoDjO1GY6+YdkK+ZqqBIBWquyV58nlSJ5S1N1IYU=
149-
github.com/fluxcd/pkg/runtime v0.75.0 h1:wIaODmU5D54nyrehTqA9oQDFoi6BbBj/24adLStXc0I=
150-
github.com/fluxcd/pkg/runtime v0.75.0/go.mod h1:iGhdaEq+lMJQTJNAFEPOU4gUJ7kt3yeDcJPZy7O9IUw=
149+
github.com/fluxcd/pkg/runtime v0.80.0 h1:vknT2vdQSGTFnAhz4xGk2ZXUWCrXh3whsISStgA57Go=
150+
github.com/fluxcd/pkg/runtime v0.80.0/go.mod h1:iGhdaEq+lMJQTJNAFEPOU4gUJ7kt3yeDcJPZy7O9IUw=
151151
github.com/fluxcd/pkg/ssa v0.51.0 h1:sFarxKZcS0J8sjq9qvs/r+1XiJqNgRodEiPjV75F8R4=
152152
github.com/fluxcd/pkg/ssa v0.51.0/go.mod h1:v+h9RC0JxWIqMTK2Eo+8Nh700AXyZChZ2TiLVj4tf3M=
153153
github.com/fluxcd/pkg/ssh v0.20.0 h1:Ak0laIYIc/L8lEfqls/LDWRW8wYPESGaravQsCRGLb8=

internal/server/event_handlers.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -432,8 +432,7 @@ func createNotifier(ctx context.Context, kubeClient client.Client, provider *api
432432
Name: provider.Spec.CertSecretRef.Name,
433433
Namespace: provider.GetNamespace(),
434434
}
435-
const insecure = false // Provider API has no insecure field, always verify certificates
436-
tlsConfig, err := secrets.TLSConfigFromSecretRef(ctx, kubeClient, secretRef, webhook, insecure)
435+
tlsConfig, err := secrets.TLSConfigFromSecretRef(ctx, kubeClient, secretRef)
437436
if err != nil {
438437
return nil, "", fmt.Errorf("failed to get TLS config: %w", err)
439438
}

0 commit comments

Comments
 (0)