refactor: move DependencyReference to apis/meta#1129
Open
Iam-Karan-Suresh wants to merge 1 commit intofluxcd:mainfrom
Open
refactor: move DependencyReference to apis/meta#1129Iam-Karan-Suresh wants to merge 1 commit intofluxcd:mainfrom
Iam-Karan-Suresh wants to merge 1 commit intofluxcd:mainfrom
Conversation
Iam-Karan-Suresh
requested review from
hiddeco and
stefanprodan
as code owners
Iam-Karan-Suresh
force-pushed
the
refactor/extract-dependencyreference-meta
branch
3 times, most recently
from
5ea7c0d to
897b9d5
Compare
matheuscscp
reviewed
Apr 14, 2026
Member
matheuscscp
left a comment
matheuscscp
left a comment
There was a problem hiding this comment.
After this change is released, we need to replace the types in kustomize-controller and helm-controller in a non-breaking way:
type DependencyReference = meta.DependencyReference| // GetDependsOn returns a NamespacedObjectReference list the object depends on. | ||
| GetDependsOn() []NamespacedObjectReference | ||
| // GetDependsOn returns a DependencyReference list the object depends on. | ||
| GetDependsOn() []DependencyReference |
Member
There was a problem hiding this comment.
This is a breaking change, and apis/meta is GA (v1.x). I'm ok with it, though, so I'll defer to other maintainers
Iam-Karan-Suresh
force-pushed
the
refactor/extract-dependencyreference-meta
branch
from
897b9d5 to
f90a31f
Compare
Iam-Karan-Suresh
force-pushed
the
refactor/extract-dependencyreference-meta
branch
2 times, most recently
from
2db907a to
98b8f46
Compare
matheuscscp
reviewed
Apr 15, 2026
Iam-Karan-Suresh
force-pushed
the
refactor/extract-dependencyreference-meta
branch
2 times, most recently
from
bbccaa6 to
3f56026
Compare
Contributor
Author
|
@matheuscscp i added the links on the command. happy to iterate based on suggestions |
matheuscscp
reviewed
Apr 15, 2026
Signed-off-by: Iam-karan-suresh <karansuresh.info@gmail.com> Signed-off-by: iam-karan-suresh <karansuresh.info@gmail.com>
Iam-Karan-Suresh
force-pushed
the
refactor/extract-dependencyreference-meta
branch
from
3f56026 to
317525d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
DependencyReferencetoapis/meta(Fix #1034)Summary
This PR moves the duplicated
DependencyReferencetype from controller-specific APIs intoapis/metato provide a single shared implementation across Flux components.Changes
DependencyReferencetoapis/metaObjectWithDependenciesto use[]DependencyReferenceMakeDependsOnhelper with CEL (@expr) supportMotivation
DependencyReferencewas duplicated across KC and HC APIs. Centralizing it inapis/metaremoves duplication and enables consistent dependency handling, including CEL-based readiness expressions used by the Flux CLI.Notes
fluxcd/flux2to use the shared type inutils.MakeDependsOn.