Address reviewer feedback; only trigger for Helm charts

Signed-off-by: Evan Anderson <evan@custcodian.dev>

Author: evankanderson

internal/controller/ocirepository_controller.go

@@ -867,7 +867,7 @@ func (r *OCIRepositoryReconciler) getArtifactRef(obj *sourcev1.OCIRepository, op
 		}
 
 		if obj.Spec.Reference.SemVer != "" {
-			return r.getTagBySemver(repo, obj.Spec.Reference.SemVer, filterTags(obj.Spec.Reference.SemverFilter), options)
+			return r.getTagBySemver(repo, obj.Spec.Reference.SemVer, filterTags(obj.Spec.Reference.SemverFilter), obj.GetLayerMediaType(), options)
 		}
 
 		if obj.Spec.Reference.Tag != "" {
@@ -880,7 +880,7 @@ func (r *OCIRepositoryReconciler) getArtifactRef(obj *sourcev1.OCIRepository, op
 
 // getTagBySemver call the remote container registry, fetches all the tags from the repository,
 // and returns the latest tag according to the semver expression.
-func (r *OCIRepositoryReconciler) getTagBySemver(repo name.Repository, exp string, filter filterFunc, options []remote.Option) (name.Reference, error) {
+func (r *OCIRepositoryReconciler) getTagBySemver(repo name.Repository, exp string, filter filterFunc, mediaType string, options []remote.Option) (name.Reference, error) {
 	tags, err := remote.List(repo, options...)
 	if err != nil {
 		return nil, err
@@ -899,10 +899,12 @@ func (r *OCIRepositoryReconciler) getTagBySemver(repo name.Repository, exp strin
 	var matchingVersions []*semver.Version
 	for _, t := range validTags {
 		// Helm translates `+` to `_` in OCI tags, because `+` is not a valid tag character.
-		versionStr := strings.Replace(t, "_", "+", 1)
+		if mediaType == "application/vnd.cncf.helm.chart.content.v1.tar+gzip" {
+			t = strings.Replace(t, "_", "+", 1)
+		}
 		// It would be even better to use `org.opencontainers.image.version` annotation
 		// if present, but that adds a fetch for each tag.
-		v, err := version.ParseVersion(versionStr)
+		v, err := version.ParseVersion(t)
 		if err != nil {
 			continue
 		}

internal/controller/ocirepository_controller_test.go

@@ -2874,6 +2874,7 @@ func TestOCIRepository_getArtifactRef(t *testing.T) {
 		name      string
 		url       string
 		reference *sourcev1.OCIRepositoryRef
+		selector  *sourcev1.OCILayerSelector
 		wantErr   bool
 		want      string
 	}{
@@ -2904,6 +2905,9 @@ func TestOCIRepository_getArtifactRef(t *testing.T) {
 			reference: &sourcev1.OCIRepositoryRef{
 				SemVer: ">= 6.1.6",
 			},
+			selector: &sourcev1.OCILayerSelector{
+				MediaType: "application/vnd.cncf.helm.chart.content.v1.tar+gzip",
+			},
 			want: server.registryHost + "/podinfo:6.1.7_ref.1234567",
 		},
 		{
@@ -2959,6 +2963,9 @@ func TestOCIRepository_getArtifactRef(t *testing.T) {
 			if tt.reference != nil {
 				obj.Spec.Reference = tt.reference
 			}
+			if tt.selector != nil {
+				obj.Spec.LayerSelector = tt.selector
+			}
 
 			opts := makeRemoteOptions(ctx, makeTransport(true), authn.DefaultKeychain, nil)
 			got, err := r.getArtifactRef(obj, opts)