golangci-lint fixes: add package comments and fix lint issues

Author: dangra

cmd/flexctl/backups.go

@@ -254,7 +254,7 @@ func getAppName() (string, error) {
 	return name, nil
 }
 
-func getApiUrl() (string, error) {
+func getAPIURL() (string, error) {
 	hostname, err := getAppName()
 	if err != nil {
 		return "", err
@@ -273,7 +273,7 @@ func newConfigShow() *cobra.Command {
 				return fmt.Errorf("backups are not enabled")
 			}
 
-			url, err := getApiUrl()
+			url, err := getAPIURL()
 			if err != nil {
 				return err
 			}
@@ -283,6 +283,7 @@ func newConfigShow() *cobra.Command {
 			if err != nil {
 				return err
 			}
+			defer resp.Body.Close() // nolint:errcheck
 
 			var rv configShowResult
 			if err := json.NewDecoder(resp.Body).Decode(&rv); err != nil {
@@ -354,7 +355,7 @@ func newConfigUpdate() *cobra.Command {
 			return err
 		}
 
-		url, err := getApiUrl()
+		url, err := getAPIURL()
 		if err != nil {
 			return err
 		}
@@ -364,6 +365,7 @@ func newConfigUpdate() *cobra.Command {
 		if err != nil {
 			return err
 		}
+		defer resp.Body.Close() // nolint:errcheck
 
 		var rv configUpdateResult
 		if err := json.NewDecoder(resp.Body).Decode(&rv); err != nil {

internal/api/handler.go

@@ -1,3 +1,4 @@
+// Package api provides HTTP handlers for the postgres management API.
 package api
 
 import (

internal/flybarman/node.go

@@ -1,3 +1,4 @@
+// Package flybarman manages barman backup nodes.
 package flybarman
 
 import (

internal/flycheck/barman.go

@@ -14,7 +14,7 @@ func CheckBarmanConnection(checks *check.CheckSuite) *check.CheckSuite {
 
 	output, err := cmd.CombinedOutput()
 	if err != nil {
-		checks.AddCheck("connection", func() (string, error) {
+		_ = checks.AddCheck("connection", func() (string, error) {
 			msg := "failed running `barman check pg`"
 			return "", errors.New(msg)
 		})
@@ -40,7 +40,7 @@ func CheckBarmanConnection(checks *check.CheckSuite) *check.CheckSuite {
 				continue
 			}
 
-			checks.AddCheck(left, func() (string, error) {
+			_ = checks.AddCheck(left, func() (string, error) {
 				if strings.Contains(right, "FAILED") {
 					return "", errors.New(right)
 				}

internal/flycheck/checks.go

@@ -1,3 +1,4 @@
+// Package flycheck implements health check handlers for fly.io postgres.
 package flycheck
 
 import (

internal/flycheck/pg.go

@@ -41,13 +41,13 @@ func CheckPostgreSQL(ctx context.Context, checks *check.CheckSuite) (*check.Chec
 		_ = repConn.Close(ctx)
 	}
 
-	checks.AddCheck("connections", func() (string, error) {
+	_ = checks.AddCheck("connections", func() (string, error) {
 		return connectionCount(ctx, localConn)
 	})
 
 	if member.Role == flypg.PrimaryRoleName {
 		// Check to see if any locks are present.
-		checks.AddCheck("cluster-locks", func() (string, error) {
+		_ = checks.AddCheck("cluster-locks", func() (string, error) {
 			if flypg.ZombieLockExists() {
 				return "", fmt.Errorf("`zombie.lock` detected")
 			}
@@ -62,7 +62,7 @@ func CheckPostgreSQL(ctx context.Context, checks *check.CheckSuite) (*check.Chec
 		if member.Active {
 			// Check that provides additional insight into disk capacity and
 			// how close we are to hitting the readonly threshold.
-			checks.AddCheck("disk-capacity", func() (string, error) {
+			_ = checks.AddCheck("disk-capacity", func() (string, error) {
 				return diskCapacityCheck(ctx, node)
 			})
 		}

internal/flycheck/role.go

@@ -13,7 +13,7 @@ import (
 // PostgreSQLRole outputs current role
 func PostgreSQLRole(ctx context.Context, checks *check.CheckSuite) (*check.CheckSuite, error) {
 	if os.Getenv("IS_BARMAN") != "" {
-		checks.AddCheck("role", func() (string, error) {
+		_ = checks.AddCheck("role", func() (string, error) {
 			return "barman", nil
 		})
 
@@ -35,7 +35,7 @@ func PostgreSQLRole(ctx context.Context, checks *check.CheckSuite) (*check.Check
 		_ = conn.Close(ctx)
 	}
 
-	checks.AddCheck("role", func() (string, error) {
+	_ = checks.AddCheck("role", func() (string, error) {
 		if flypg.ZombieLockExists() {
 			return "zombie", nil
 		}

internal/flycheck/vm.go

@@ -15,16 +15,16 @@ import (
 
 // CheckVM for system / disk checks
 func CheckVM(checks *check.CheckSuite) *check.CheckSuite {
-	checks.AddCheck("checkDisk", func() (string, error) {
+	_ = checks.AddCheck("checkDisk", func() (string, error) {
 		return checkDisk("/data/")
 	})
 
-	checks.AddCheck("checkLoad", checkLoad)
+	_ = checks.AddCheck("checkLoad", checkLoad)
 
 	pressureNames := []string{"memory", "cpu", "io"}
 	for _, n := range pressureNames {
 		name := n
-		checks.AddCheck(name, func() (string, error) {
+		_ = checks.AddCheck(name, func() (string, error) {
 			return checkPressure(name)
 		})
 	}

internal/flypg/admin/admin.go

@@ -1,3 +1,4 @@
+// Package admin provides administrative utilities for managing postgres.
 package admin
 
 import (

internal/flypg/flypg.go

@@ -1,3 +1,4 @@
+// Package flypg manages the postgres cluster lifecycle on fly.io.
 package flypg
 
 import (