Skip to content

Commit 182dd50

Browse files
authored
Allow HTTP registry for Knative Serving in devbox (#7302)
* Allow HTTP registry for Knative Serving in devbox Patch the knative-serving config-deployment ConfigMap to skip tag-to-digest resolution for the local registry and allow HTTP registries, so Knative Service revisions can pull images from the devbox local registry. Signed-off-by: Kevin Su <pingsutw@apache.org> * Apply same patch to dev kustomization Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>
1 parent 1dd0464 commit 182dd50

4 files changed

Lines changed: 22 additions & 0 deletions

File tree

docker/devbox-bundled/kustomize/complete/kustomization.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,15 @@ patches:
4747
namespace: knative-serving
4848
data:
4949
"localhost": ""
50+
- patch: |-
51+
apiVersion: v1
52+
kind: ConfigMap
53+
metadata:
54+
name: config-deployment
55+
namespace: knative-serving
56+
data:
57+
registries-skipping-tag-resolving: "localhost:30000,kind-registry:5000"
58+
allow-http-registry: "true"
5059
- patch: |-
5160
apiVersion: rbac.authorization.k8s.io/v1
5261
kind: ClusterRole

docker/devbox-bundled/kustomize/dev/kustomization.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,15 @@ patches:
3737
namespace: knative-serving
3838
data:
3939
"localhost": ""
40+
- patch: |-
41+
apiVersion: v1
42+
kind: ConfigMap
43+
metadata:
44+
name: config-deployment
45+
namespace: knative-serving
46+
data:
47+
registries-skipping-tag-resolving: "localhost:30000,kind-registry:5000"
48+
allow-http-registry: "true"
4049
- patch: |-
4150
apiVersion: rbac.authorization.k8s.io/v1
4251
kind: ClusterRole

docker/devbox-bundled/manifests/complete.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7873,7 +7873,9 @@ metadata:
78737873
---
78747874
apiVersion: v1
78757875
data:
7876+
allow-http-registry: "true"
78767877
queue-sidecar-image: gcr.io/knative-releases/knative.dev/serving/cmd/queue@sha256:d0be939fdfb469e52e999eb65f39466d18f029984a782affa26322c9fec6db78
7878+
registries-skipping-tag-resolving: localhost:30000,kind-registry:5000
78777879
kind: ConfigMap
78787880
metadata:
78797881
annotations:

docker/devbox-bundled/manifests/dev.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7589,7 +7589,9 @@ metadata:
75897589
---
75907590
apiVersion: v1
75917591
data:
7592+
allow-http-registry: "true"
75927593
queue-sidecar-image: gcr.io/knative-releases/knative.dev/serving/cmd/queue@sha256:d0be939fdfb469e52e999eb65f39466d18f029984a782affa26322c9fec6db78
7594+
registries-skipping-tag-resolving: localhost:30000,kind-registry:5000
75937595
kind: ConfigMap
75947596
metadata:
75957597
annotations:

0 commit comments

Comments
 (0)