Skip to content

Commit 3dca5c9

Browse files
fix(helm): set catalog-cache to noop when datacatalog is disabled
When datacatalog.enabled=false in flyte-core, the catalog-cache config still defaulted to type: datacatalog, causing DNS failures on every task execution since the datacatalog service does not exist. Conditionally render catalog.yaml with type: noop when datacatalog is disabled, preventing connection attempts to a non-existent datacatalog endpoint. Closes #7155 Signed-off-by: Varun Nuthalapati <nuthalapativarun@gmail.com>
1 parent 669c05c commit 3dca5c9

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

charts/flyte-core/templates/propeller/configmap.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,15 @@ data:
99
{{- with .Values.configmap.admin }}
1010
admin.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
1111
{{- end }}
12+
{{- if .Values.datacatalog.enabled }}
1213
{{- with .Values.configmap.catalog }}
1314
catalog.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
1415
{{- end }}
16+
{{- else }}
17+
catalog.yaml: |
18+
catalog-cache:
19+
type: noop
20+
{{- end }}
1521
{{- with .Values.configmap.catalog_cache }}
1622
catalog_cache.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
1723
{{- end }}

0 commit comments

Comments
 (0)