Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ type AppConfig struct {
CacheTTL time.Duration `json:"cacheTtl" pflag:",TTL for app status cache"`
}


const appConfigSectionKey = "apps"

var defaultAppConfig = &AppConfig{
Expand Down
1 change: 0 additions & 1 deletion app/internal/k8s/app_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,6 @@ func TestSubscribe_ReceivesEvent(t *testing.T) {
}
}


func TestSubscribe_AppSpecificDoesNotReceiveOtherApps(t *testing.T) {
c := testClient(t)
ch := c.Subscribe("app1")
Expand Down
2 changes: 1 addition & 1 deletion app/internal/service/internal_app_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ import (
appconfig "github.com/flyteorg/flyte/v2/app/internal/config"
flyteapp "github.com/flyteorg/flyte/v2/gen/go/flyteidl2/app"
"github.com/flyteorg/flyte/v2/gen/go/flyteidl2/app/appconnect"
flytecoreapp "github.com/flyteorg/flyte/v2/gen/go/flyteidl2/core"
"github.com/flyteorg/flyte/v2/gen/go/flyteidl2/common"
flytecoreapp "github.com/flyteorg/flyte/v2/gen/go/flyteidl2/core"
)

// mockAppK8sClient is a testify mock for AppK8sClientInterface.
Expand Down
1 change: 0 additions & 1 deletion app/internal/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
appconfig "github.com/flyteorg/flyte/v2/app/internal/config"
appk8s "github.com/flyteorg/flyte/v2/app/internal/k8s"
"github.com/flyteorg/flyte/v2/app/internal/service"
"github.com/flyteorg/flyte/v2/gen/go/flyteidl2/app/appconnect"
knativeapp "github.com/flyteorg/flyte/v2/flytestdlib/app"
)

Expand Down
10 changes: 6 additions & 4 deletions executor/pkg/controller/taskaction_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ type fakePlugin struct {
abortCalls int
}

func (f *fakePlugin) GetID() string { return f.id }
func (f *fakePlugin) GetProperties() pluginsCore.PluginProperties { return pluginsCore.PluginProperties{} }
func (f *fakePlugin) GetID() string { return f.id }
func (f *fakePlugin) GetProperties() pluginsCore.PluginProperties {
return pluginsCore.PluginProperties{}
}
func (f *fakePlugin) Handle(_ context.Context, _ pluginsCore.TaskExecutionContext) (pluginsCore.Transition, error) {
return pluginsCore.UnknownTransition, nil
}
Expand Down Expand Up @@ -540,8 +542,8 @@ var _ = Describe("TaskAction Controller", func() {
BeforeEach(func() {
resource := &flyteorgv1.TaskAction{
ObjectMeta: metav1.ObjectMeta{
Name: abortResourceName,
Namespace: "default",
Name: abortResourceName,
Namespace: "default",
Finalizers: []string{taskActionFinalizer},
},
Spec: flyteorgv1.TaskActionSpec{
Expand Down
3 changes: 2 additions & 1 deletion executor/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
"sigs.k8s.io/controller-runtime/pkg/webhook"

"github.com/flyteorg/flyte/v2/flytestdlib/app"
flyteorgv1 "github.com/flyteorg/flyte/v2/executor/api/v1"
"github.com/flyteorg/flyte/v2/executor/pkg/config"
"github.com/flyteorg/flyte/v2/executor/pkg/controller"
Expand All @@ -28,6 +27,8 @@
"github.com/flyteorg/flyte/v2/flyteplugins/go/tasks/pluginmachinery/catalog"
cachecatalog "github.com/flyteorg/flyte/v2/flyteplugins/go/tasks/pluginmachinery/catalog/cache_service"
webhookConfig "github.com/flyteorg/flyte/v2/flyteplugins/go/tasks/pluginmachinery/secret/config"
"github.com/flyteorg/flyte/v2/flytestdlib/app"
"git

Check failure on line 31 in executor/setup.go

View workflow job for this annotation

GitHub Actions / test (executor)

string literal not terminated

Check failure on line 31 in executor/setup.go

View workflow job for this annotation

GitHub Actions / test (executor)

string literal not terminated
"github.com/flyteorg/flyte/v2/flytestdlib/promutils"
"github.com/flyteorg/flyte/v2/flytestdlib/storage"
"github.com/flyteorg/flyte/v2/gen/go/flyteidl2/workflow/workflowconnect"
Expand Down
6 changes: 3 additions & 3 deletions flyteidl2/task/run.proto
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ message RunSpec {
// Deprecated, please use CacheConfig.OverwriteCache instead
bool overwrite_cache = 5 [deprecated = true];

// the specific cluster that this action should be executed on. this value will be used as the
// default for all actions in the run unless overridden.
string cluster = 6;
// the queue name that this run should be executed on.
// Queue name is unique within an org so it can be used as an id to reference the queue.
string queue = 6;

// Encapsulates user settings pertaining to offloaded data (i.e. Blobs, Schema, query data, etc.).
RawDataStorage raw_data_storage = 7;
Expand Down
6 changes: 3 additions & 3 deletions flyteidl2/workflow/run_definition.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ message TaskAction {
// Enables caching when set and specifies the cache version to use.
google.protobuf.StringValue cache_key = 3;

// the specific cluster that this action should be executed on. if not set, the cluster from the
// `RunSpec` will be used.
string cluster = 4;
// the specific queue that this action should be executed on.
// this value will be used to resolve the full queue id and store it in 'assigned_queue' field.
string queue = 4;
}

// TraceAction is used to define a trace action that can be used to track the execution of an action that's managed
Expand Down
144 changes: 72 additions & 72 deletions gen/go/flyteidl2/task/run.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/go/flyteidl2/task/run.pb.validate.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading