Skip to content

fix(helm): set catalog-cache to noop when datacatalog is disabled in flyte-core #7234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuthalapativarun wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(helm): set catalog-cache to noop when datacatalog is disabled in flyte-core #7234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb9a9c3
fix(helm): set catalog-cache to noop when datacatalog is disabled
nuthalapativarun Apr 18, 2026
4c36727
chore: regenerate helm charts
nuthalapativarun May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/flyte-core/templates/propeller/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@ data:
{{- with .Values.configmap.admin }}
admin.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
{{- end }}
{{- if .Values.datacatalog.enabled }}
{{- with .Values.configmap.catalog }}
catalog.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
{{- end }}
{{- else }}
catalog.yaml: |
catalog-cache:
type: noop
{{- end }}
{{- with .Values.configmap.catalog_cache }}
catalog_cache.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
{{- end }}
Expand Down
10 changes: 4 additions & 6 deletions deployment/eks/flyte_helm_dataplane_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,9 @@ data:
capacity: 1000
rate: 500
type: admin
catalog.yaml: |
catalog.yaml: |
catalog-cache:
endpoint: datacatalog:89
insecure: true
type: datacatalog
type: noop
copilot.yaml: |
plugins:
k8s:
Expand Down Expand Up @@ -436,7 +434,7 @@ spec:
template:
metadata:
annotations:
configChecksum: "97265f70f47a3e1ac710100719e47cebd553a1185229e18d8ed4bbe76200013"
configChecksum: "9a9f82053df3a70b3887205eaabf5bfcee55c8349fbe1b036d69943f0ffef34"
prometheus.io/path: "/metrics"
prometheus.io/port: "10254"
labels:
Expand Down Expand Up @@ -522,7 +520,7 @@ spec:
app.kubernetes.io/name: flyte-pod-webhook
app.kubernetes.io/version: v1.16.6
annotations:
configChecksum: "97265f70f47a3e1ac710100719e47cebd553a1185229e18d8ed4bbe76200013"
configChecksum: "9a9f82053df3a70b3887205eaabf5bfcee55c8349fbe1b036d69943f0ffef34"
prometheus.io/path: "/metrics"
prometheus.io/port: "10254"
spec:
Expand Down
10 changes: 4 additions & 6 deletions deployment/gcp/flyte_helm_dataplane_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,9 @@ data:
capacity: 1000
rate: 500
type: admin
catalog.yaml: |
catalog.yaml: |
catalog-cache:
endpoint: datacatalog:89
insecure: true
type: datacatalog
type: noop
copilot.yaml: |
plugins:
k8s:
Expand Down Expand Up @@ -444,7 +442,7 @@ spec:
template:
metadata:
annotations:
configChecksum: "0d5f06fa15eb8ba65d62486dce30297ab18e1ca95e55db51819bfa2ce47c5de"
configChecksum: "6efab023be81e64928658e841bbff6631ea3c96c1b09a9f487dbc19a1520301"
prometheus.io/path: "/metrics"
prometheus.io/port: "10254"
labels:
Expand Down Expand Up @@ -529,7 +527,7 @@ spec:
app.kubernetes.io/name: flyte-pod-webhook
app.kubernetes.io/version: v1.16.6
annotations:
configChecksum: "0d5f06fa15eb8ba65d62486dce30297ab18e1ca95e55db51819bfa2ce47c5de"
configChecksum: "6efab023be81e64928658e841bbff6631ea3c96c1b09a9f487dbc19a1520301"
prometheus.io/path: "/metrics"
prometheus.io/port: "10254"
spec:
Expand Down
5 changes: 3 additions & 2 deletions deployment/sandbox/flyte_helm_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,7 @@ data:
resource_manager.yaml: |
propeller:
resourcemanager:
redis: null
type: noop
storage.yaml: |
storage:
Expand Down Expand Up @@ -7227,7 +7228,7 @@ spec:
template:
metadata:
annotations:
configChecksum: "a7f80c4bc2e56c53048e7fdda25f8c153b8f22ee6cfbb8bc7fe0d0d6855a0c3"
configChecksum: "d32e90ba21c593bb965c40e3ca48de856a3df06dec72a42212308fdcc91883e"
prometheus.io/path: "/metrics"
prometheus.io/port: "10254"
labels:
Expand Down Expand Up @@ -7305,7 +7306,7 @@ spec:
app.kubernetes.io/name: flyte-pod-webhook
app.kubernetes.io/version: v1.16.6
annotations:
configChecksum: "a7f80c4bc2e56c53048e7fdda25f8c153b8f22ee6cfbb8bc7fe0d0d6855a0c3"
configChecksum: "d32e90ba21c593bb965c40e3ca48de856a3df06dec72a42212308fdcc91883e"
prometheus.io/path: "/metrics"
prometheus.io/port: "10254"
spec:
Expand Down
Loading