Correctly filter clippy results to include the current file only#38
Open
OmegaJak wants to merge 2 commits into
Open
Correctly filter clippy results to include the current file only#38OmegaJak wants to merge 2 commits into
OmegaJak wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37.
Made a rust project in samples that can be opened as root for testing, not sure if that's how you like to do things but it helped me.
The clippy
target.src_paththat was being looked at always reported the main file of the project, not the current file. To filter to the current file, you have to look at the spans being returned.Tested on Windows (where I had to do the silly \ to / conversion).