-
Notifications
You must be signed in to change notification settings - Fork 29
Expand file tree
/
Copy pathLoanAPITests.java
More file actions
2151 lines (1581 loc) · 73.6 KB
/
Copy pathLoanAPITests.java
File metadata and controls
2151 lines (1581 loc) · 73.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package api.loans;
import static api.requests.RequestsAPICreationTests.setupMissingItem;
import static api.support.fakes.PublishedEvents.byEventType;
import static api.support.fixtures.SettingsFixture.utcTimezoneConfiguration;
import static api.support.http.AdditionalHttpStatusCodes.UNPROCESSABLE_ENTITY;
import static api.support.http.CqlQuery.queryFromTemplate;
import static api.support.http.Limit.limit;
import static api.support.http.Offset.offset;
import static api.support.matchers.EventMatchers.isValidLoanDueDateChangedEvent;
import static api.support.matchers.TextDateTimeMatcher.isEquivalentTo;
import static api.support.matchers.UUIDMatcher.is;
import static api.support.matchers.ValidationErrorMatchers.hasErrorWith;
import static api.support.matchers.ValidationErrorMatchers.hasMessage;
import static api.support.matchers.ValidationErrorMatchers.hasMessageContaining;
import static api.support.matchers.ValidationErrorMatchers.hasNullParameter;
import static api.support.matchers.ValidationErrorMatchers.hasUUIDParameter;
import static java.lang.String.format;
import static java.net.HttpURLConnection.HTTP_NOT_FOUND;
import static java.time.ZoneOffset.UTC;
import static org.folio.circulation.domain.representations.ItemProperties.CALL_NUMBER_COMPONENTS;
import static org.folio.circulation.domain.representations.LoanProperties.BORROWER;
import static org.folio.circulation.support.StreamToListMapper.toList;
import static org.folio.circulation.support.utils.DateFormatUtil.formatDateTime;
import static org.hamcrest.CoreMatchers.allOf;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.containsInAnyOrder;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.greaterThan;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.nullValue;
import static org.hamcrest.core.Is.is;
import static org.junit.jupiter.api.Assertions.assertTrue;
import java.net.HttpURLConnection;
import java.time.Period;
import java.time.ZonedDateTime;
import java.util.List;
import java.util.Set;
import java.util.UUID;
import java.util.concurrent.ThreadLocalRandom;
import java.util.concurrent.TimeUnit;
import java.util.function.Function;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import java.util.stream.Stream;
import org.awaitility.Awaitility;
import org.folio.circulation.support.http.client.Response;
import org.folio.circulation.support.json.JsonObjectArrayPropertyFetcher;
import org.junit.jupiter.api.Test;
import api.support.APITests;
import api.support.MultipleJsonRecords;
import api.support.builders.AccountBuilder;
import api.support.builders.ItemBuilder;
import api.support.builders.LoanBuilder;
import api.support.builders.UserBuilder;
import api.support.fakes.FakePubSub;
import api.support.http.IndividualResource;
import api.support.http.ItemResource;
import api.support.http.UserResource;
import io.vertx.core.json.JsonArray;
import io.vertx.core.json.JsonObject;
import lombok.val;
class LoanAPITests extends APITests {
@Test
void canCreateALoan() {
UUID id = UUID.randomUUID();
IndividualResource smallAngryPlanet = itemsFixture.basedUponSmallAngryPlanet(
item -> item
.withEnumeration("v.70:no.1-6")
.withChronology("1987:Jan.-June")
.withVolume("testVolume")
.withDisplaySummary("testDisplaySummary"));
UUID itemId = smallAngryPlanet.getId();
val user = usersFixture.charlotte();
UUID userId = user.getId();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
IndividualResource response = loansFixture.createLoan(new LoanBuilder()
.withId(id)
.open()
.withUserId(userId)
.withItemId(itemId)
.withLoanDate(loanDate)
.withDueDate(dueDate));
JsonObject loan = response.getJson();
assertThat("id does not match",
loan.getString("id"), is(id.toString()));
assertThat("user id does not match",
loan.getString("userId"), is(userId.toString()));
assertThat("item id does not match",
loan.getString("itemId"), is(itemId.toString()));
assertThat("loan date does not match",
loan.getString("loanDate"), is("2017-02-27T10:23:43.000Z"));
assertThat("status is not open",
loan.getJsonObject("status").getString("name"), is("Open"));
assertThat("action is not checkedout",
loan.getString("action"), is("checkedout"));
loanHasLoanPolicyProperties(loan, loanPoliciesFixture.canCirculateRolling());
assertThat("ID is taken from item",
loan.getJsonObject("item").getString("id"), is(itemId));
assertThat("title is taken from instance",
loan.getJsonObject("item").getString("title"),
is("The Long Way to a Small, Angry Planet"));
assertThat("barcode is taken from item",
loan.getJsonObject("item").getString("barcode"),
is("036000291452"));
assertThat("call number is 123456", loan.getJsonObject("item")
.getString("callNumber"), is("123456"));
assertThat(loan.getJsonObject("item").encode() + " contains 'materialType'",
loan.getJsonObject("item").containsKey("materialType"), is(true));
assertThat("materialType is book", loan.getJsonObject("item")
.getJsonObject("materialType").getString("name"), is("Book"));
assertThat("item has contributors",
loan.getJsonObject("item").containsKey("contributors"), is(true));
assertThat("has item enumeration",
loan.getJsonObject("item").getString("enumeration"), is("v.70:no.1-6"));
assertThat("has item chronology",
loan.getJsonObject("item").getString("chronology"), is("1987:Jan.-June"));
assertThat("has item volume",
loan.getJsonObject("item").getString("volume"), is("testVolume"));
assertThat("has item displaySummary",
loan.getJsonObject("item").getString("displaySummary"), is("testDisplaySummary"));
JsonArray contributors = loan.getJsonObject("item").getJsonArray("contributors");
assertThat("item has a single contributor",
contributors.size(), is(1));
assertThat("Becky Chambers is a contributor",
contributors.getJsonObject(0).getString("name"), is("Chambers, Becky"));
assertThat("has item status",
loan.getJsonObject("item").containsKey("status"), is(true));
assertThat("status is taken from item",
loan.getJsonObject("item").getJsonObject("status").getString("name"),
is("Checked out"));
assertThat("Should not have snapshot of item status, as current status is included",
loan.containsKey("itemStatus"), is(false));
assertThat("should have change metadata",
loan.containsKey("metadata"), is(true));
JsonObject changeMetadata = loan.getJsonObject("metadata");
assertThat("change metadata should have created date",
changeMetadata.containsKey("createdDate"), is(true));
assertThat("change metadata should have updated date",
changeMetadata.containsKey("updatedDate"), is(true));
assertThat("due date does not match",
loan.getString("dueDate"), isEquivalentTo(dueDate));
JsonObject item = itemsClient.getById(itemId).getJson();
assertThat("item status is not checked out",
item.getJsonObject("status").getString("name"), is("Checked out"));
assertThat("item status snapshot in storage is not checked out",
loansStorageClient.getById(id).getJson().getString("itemStatus"),
is("Checked out"));
assertThat("has item enumeration",
item.getString("enumeration"), is("v.70:no.1-6"));
assertThat("has item chronology",
item.getString("chronology"), is("1987:Jan.-June"));
assertThat("has item volume",
item.getString("volume"), is("testVolume"));
assertThat("isDcb should be false",
loan.getString("isDcb"), is("false"));
loanHasExpectedProperties(loan, user);
}
@Test
void createLoanForDcbItem() {
IndividualResource instance = instancesFixture.basedUponDunkirk();
IndividualResource holdings = holdingsFixture.defaultWithHoldings(instance.getId());
var instanceTitle = "virtual Title";
IndividualResource locationsResource = locationsFixture.mainFloor();
final IndividualResource circulationItem = circulationItemsFixture.createCirculationItem(
"100002222", holdings.getId(), locationsResource.getId(), instanceTitle);
loansFixture.createLoan(circulationItem, usersFixture.jessica());
JsonObject loan = loansFixture.getLoans().getFirst();
assertThat("isDcb should be true",
loan.getString("isDcb"), is("true"));
}
@Test
void createLoanForDcbUser() {
IndividualResource instance = instancesFixture.basedUponDunkirk();
IndividualResource holdings = holdingsFixture.defaultWithHoldings(instance.getId());
var instanceTitle = "title";
IndividualResource locationsResource = locationsFixture.mainFloor();
final IndividualResource circulationItem = circulationItemsFixture.createCirculationItemForDcb(
"100002222", holdings.getId(), locationsResource.getId(), instanceTitle, false);
loansFixture.createLoan(circulationItem, usersFixture.groot());
JsonObject loan = loansFixture.getLoans().getFirst();
assertThat("isDcb should be true",
loan.getString("isDcb"), is("true"));
}
@Test
void createLoanForDcbUserAndDcbItem() {
IndividualResource instance = instancesFixture.basedUponDunkirk();
IndividualResource holdings = holdingsFixture.defaultWithHoldings(instance.getId());
var instanceTitle = "virtual Title";
IndividualResource locationsResource = locationsFixture.mainFloor();
final IndividualResource circulationItem = circulationItemsFixture.createCirculationItem(
"100002222", holdings.getId(), locationsResource.getId(), instanceTitle);
loansFixture.createLoan(circulationItem, usersFixture.groot());
JsonObject loan = loansFixture.getLoans().getFirst();
assertThat("isDcb should be true",
loan.getString("isDcb"), is("true"));
}
@Test
void canGetLoansWithAdditionalFieldsRequiredForDueDateSlip() {
loansFixture.createLoan(itemsFixture.basedUponSmallAngryPlanet(), usersFixture.KimJames());
JsonObject loan = loansFixture.getLoans().getFirst();
assertThat("Borrower has preferredFirstName",
loan.getJsonObject("borrower").containsKey("preferredFirstName"), is(true));
assertThat("Borrower has patronGroup",
loan.getJsonObject("borrower").containsKey("patronGroup"), is(true));
assertThat("Item has primaryContributor",
loan.getJsonObject("item").containsKey("primaryContributor"), is(true));
assertThat("Item has editions",
loan.getJsonObject("item").containsKey("editions"), is(true));
assertThat("Item has publication years",
loan.getJsonObject("item").containsKey("datesOfPublication"), is(true));
assertThat("Item has series statement",
loan.getJsonObject("item").containsKey("seriesStatements"), is(true));
}
@Test
void borrowerPreferredFirstNameFallsBackToFirstNameWhenBlankOrNull() {
testPreferredFirstName("Jones", "Steven", "", "Steven", itemsFixture.basedUponSmallAngryPlanet());
testPreferredFirstName("Rodwell", "James", null, "James", itemsFixture.basedUponNod());
testPreferredFirstName("Kim", "Jam", "kimJ", "kimJ", itemsFixture.basedUponDunkirk());
}
private void testPreferredFirstName(String lastName, String firstName, String preferredFirstName,
String expectedFirstName, IndividualResource item) {
var user = usersFixture.from(new UserBuilder()
.withPreferredFirstName(lastName, firstName, preferredFirstName)
.withActive(true));
var loan = loansFixture.createLoan(item, user);
var loanJson = loansFixture.getLoanById(loan.getId()).getJson();
assertThat("Borrower preferredFirstName logic",
loanJson.getJsonObject("borrower").getString("preferredFirstName"),
is(expectedFirstName));
}
@Test
void canGetLoanWithoutOpenFeesFines() {
UUID id = UUID.randomUUID();
UUID itemId = itemsFixture.basedUponSmallAngryPlanet().getId();
IndividualResource user = usersFixture.charlotte();
UUID userId = user.getId();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
IndividualResource response = loansFixture.createLoan(new LoanBuilder()
.withId(id)
.open()
.withUserId(userId)
.withItemId(itemId)
.withLoanDate(loanDate)
.withDueDate(dueDate));
accountsClient.create(new AccountBuilder()
.feeFineStatusOpen()
.withLoan(response)
.feeFineStatusClosed()
.withRemainingFeeFine(150)
);
JsonObject loan = loansFixture.getLoanById(id).getJson();
assertLoanHasFeeFinesProperties(loan, 0);
}
@Test
void canGetMultipleFeesFinesForSingleLoan() {
UUID id = UUID.randomUUID();
UUID itemId = itemsFixture.basedUponSmallAngryPlanet().getId();
IndividualResource user = usersFixture.charlotte();
UUID userId = user.getId();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
IndividualResource response = loansFixture.createLoan(new LoanBuilder()
.withId(id)
.open()
.withUserId(userId)
.withItemId(itemId)
.withLoanDate(loanDate)
.withDueDate(dueDate));
accountsClient.create(new AccountBuilder()
.feeFineStatusOpen()
.withLoan(response)
.withRemainingFeeFine(150)
);
JsonObject loan = loansFixture.getLoanById(id).getJson();
assertLoanHasFeeFinesProperties(loan, 150d);
accountsClient.create(new AccountBuilder()
.feeFineStatusOpen()
.withLoan(response)
.withRemainingFeeFine(150)
);
loan = loansFixture.getLoanById(id).getJson();
assertLoanHasFeeFinesProperties(loan, 300d);
}
@Test
void canGetMultipleFeesFinesForMultipleLoans() {
settingsClient.create(utcTimezoneConfiguration());
IndividualResource item1 = itemsFixture.basedUponSmallAngryPlanet();
final ItemResource item2 = itemsFixture.basedUponNod();
final IndividualResource user1 = usersFixture.jessica();
final IndividualResource user2 = usersFixture.steve();
IndividualResource loan1 = checkOutFixture.checkOutByBarcode(
item1, user1, ZonedDateTime.of(2018, 4, 21, 11, 21, 43, 0, UTC));
IndividualResource loan2 = checkOutFixture.checkOutByBarcode(
item2, user2, ZonedDateTime.of(2018, 4, 21, 11, 21, 43, 0, UTC));
accountsClient.create(new AccountBuilder()
.feeFineStatusOpen()
.withLoan(loan1)
.withRemainingFeeFine(100)
);
accountsClient.create(new AccountBuilder()
.feeFineStatusOpen()
.withLoan(loan1)
.withRemainingFeeFine(100)
);
accountsClient.create(new AccountBuilder()
.feeFineStatusOpen()
.withLoan(loan2)
.withRemainingFeeFine(99)
);
accountsClient.create(new AccountBuilder()
.feeFineStatusOpen()
.withLoan(loan2)
.withRemainingFeeFine(1000)
);
MultipleJsonRecords loans = loansFixture.getAllLoans();
JsonObject fetchedLoan1 = loans.getById(loan1.getId());
JsonObject fetchedLoan2 = loans.getById(loan2.getId());
assertLoanHasFeeFinesProperties(fetchedLoan1, 200);
assertLoanHasFeeFinesProperties(fetchedLoan2, 1099);
}
@Test
void canCreateALoanAtASpecificLocation() {
UUID id = UUID.randomUUID();
IndividualResource smallAngryPlanet = itemsFixture.basedUponSmallAngryPlanet(
builder -> builder
.withEnumeration("v.70:no.1-6")
.withChronology("1987:Jan.-June")
.withVolume("testVolume"));
UUID itemId = smallAngryPlanet.getId();
UUID userId = usersFixture.charlotte().getId();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
val loanBuilder = new LoanBuilder()
.withId(id)
.open()
.withUserId(userId)
.withItemId(itemId)
.withLoanDate(loanDate)
.withDueDate(dueDate);
// Prepare loan
loansFixture.createLoan(loanBuilder.withUserId(userId));
IndividualResource response = loansClient.createAtSpecificLocation(loanBuilder);
JsonObject loan = response.getJson();
assertThat("id does not match",
loan.getString("id"), is(id.toString()));
assertThat("user id does not match",
loan.getString("userId"), is(userId.toString()));
assertThat("item id does not match",
loan.getString("itemId"), is(itemId.toString()));
assertThat("loan date does not match",
loan.getString("loanDate"), is("2017-02-27T10:23:43.000Z"));
assertThat("status is not open",
loan.getJsonObject("status").getString("name"), is("Open"));
assertThat("action is not checkedout",
loan.getString("action"), is("checkedout"));
//TODO: Loan Policy should be stored - maybe only works for renewal, possible bug?
// assertThat("last loan policy should be stored",
// loan.getString("loanPolicyId"), is(APITestSuite.canCirculateRollingLoanPolicyId().toString()));
assertThat("title is taken from instance",
loan.getJsonObject("item").getString("title"),
is("The Long Way to a Small, Angry Planet"));
assertThat("barcode is taken from item",
loan.getJsonObject("item").getString("barcode"),
is("036000291452"));
assertThat("call number is 123456", loan.getJsonObject("item")
.getString("callNumber"), is("123456"));
assertThat(loan.getJsonObject("item").encode() + " contains 'materialType'",
loan.getJsonObject("item").containsKey("materialType"), is(true));
assertThat("materialType is book", loan.getJsonObject("item")
.getJsonObject("materialType").getString("name"), is("Book"));
assertThat("item has contributors",
loan.getJsonObject("item").containsKey("contributors"), is(true));
JsonArray contributors = loan.getJsonObject("item").getJsonArray("contributors");
assertThat("item has a single contributor",
contributors.size(), is(1));
assertThat("Becky Chambers is a contributor",
contributors.getJsonObject(0).getString("name"), is("Chambers, Becky"));
assertThat("has item status",
loan.getJsonObject("item").containsKey("status"), is(true));
assertThat("status is taken from item",
loan.getJsonObject("item").getJsonObject("status").getString("name"),
is("Checked out"));
assertThat("has item enumeration",
loan.getJsonObject("item").getString("enumeration"), is("v.70:no.1-6"));
assertThat("has item chronology",
loan.getJsonObject("item").getString("chronology"), is("1987:Jan.-June"));
assertThat("has item volume",
loan.getJsonObject("item").getString("volume"), is("testVolume"));
assertThat("Should not have snapshot of item status, as current status is included",
loan.containsKey("itemStatus"), is(false));
assertThat("should have change metadata",
loan.containsKey("metadata"), is(true));
JsonObject changeMetadata = loan.getJsonObject("metadata");
assertThat("change metadata should have created date",
changeMetadata.containsKey("createdDate"), is(true));
assertThat("change metadata should have updated date",
changeMetadata.containsKey("updatedDate"), is(true));
assertThat("due date does not match",
loan.getString("dueDate"), isEquivalentTo(dueDate));
JsonObject item = itemsClient.getById(itemId).getJson();
assertThat("item status is not checked out",
item.getJsonObject("status").getString("name"), is("Checked out"));
assertThat("item status snapshot in storage is not checked out",
loansStorageClient.getById(id).getJson().getString("itemStatus"),
is("Checked out"));
assertThat("has item enumeration",
item.getString("enumeration"), is("v.70:no.1-6"));
assertThat("has item chronology",
item.getString("chronology"), is("1987:Jan.-June"));
assertThat("has item volume",
item.getString("volume"), is("testVolume"));
}
@Test
void cannotCreateALoanForUnknownItem() {
UUID id = UUID.randomUUID();
UUID userId = usersFixture.charlotte().getId();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
final UUID unknownItemId = UUID.randomUUID();
final Response response = loansFixture.attemptToCreateLoan(new LoanBuilder()
.open()
.withId(id)
.withUserId(userId)
.withItemId(unknownItemId)
.withLoanDate(loanDate)
.withDueDate(dueDate),
UNPROCESSABLE_ENTITY);
assertThat(response.getJson(), hasErrorWith(allOf(
hasMessage(format("No item with ID %s could be found", unknownItemId)),
hasUUIDParameter("itemId", unknownItemId))));
}
@Test
void cannotCreateALoanWithUnknownCheckInServicePointId() {
UUID id = UUID.randomUUID();
UUID itemId = itemsFixture.basedUponSmallAngryPlanet().getId();
UUID userId = usersFixture.charlotte().getId();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
final UUID unknownServicePointId = UUID.randomUUID();
final Response response = loansFixture.attemptToCreateLoan(new LoanBuilder()
.withId(id)
.withCheckinServicePointId(unknownServicePointId)
.closed()
.withUserId(userId)
.withItemId(itemId)
.withLoanDate(loanDate)
.withDueDate(dueDate), UNPROCESSABLE_ENTITY);
assertThat(response.getJson(), hasErrorWith(allOf(
hasMessage("Check In Service Point does not exist"),
hasUUIDParameter("checkinServicePointId", unknownServicePointId))));
}
@Test
void cannotCreateALoanWithUnknownCheckOutServicePointId() {
UUID id = UUID.randomUUID();
UUID itemId = itemsFixture.basedUponSmallAngryPlanet().getId();
UUID userId = usersFixture.charlotte().getId();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
final UUID unknownServicePointId = UUID.randomUUID();
final Response response = loansFixture.attemptToCreateLoan(new LoanBuilder()
.withId(id)
.withCheckoutServicePointId(unknownServicePointId)
.open()
.withUserId(userId)
.withItemId(itemId)
.withLoanDate(loanDate)
.withDueDate(dueDate), UNPROCESSABLE_ENTITY);
assertThat(response.getJson(), hasErrorWith(allOf(
hasMessage("Check Out Service Point does not exist"),
hasUUIDParameter("checkoutServicePointId", unknownServicePointId))));
}
@Test
void cannotCreateClosedLoanWithoutUserId() {
UUID itemId = itemsFixture.basedUponSmallAngryPlanet().getId();
final Response response = loansFixture.attemptToCreateLoan(new LoanBuilder()
.withItemId(itemId)
.closed()
.withNoUserId(),
UNPROCESSABLE_ENTITY);
assertThat(response.getJson(), hasErrorWith(allOf(
hasMessage("user is not found"),
hasNullParameter("userId"))));
}
@Test
void canCreateClosedLoanInSpecificLocationWithoutUserId() {
UUID loanId = UUID.randomUUID();
UUID checkinServicePointId = servicePointsFixture.cd1().getId();
UUID itemId = itemsFixture.basedUponSmallAngryPlanet().getId();
LoanBuilder loanBuilder = new LoanBuilder()
.withId(loanId)
.withItemId(itemId)
.withCheckinServicePointId(checkinServicePointId)
.closed()
.withNoUserId();
UUID userId = usersFixture.charlotte().getId();
loansFixture.createLoan(loanBuilder.withUserId(userId));
loansFixture.createLoanAtSpecificLocation(loanId, loanBuilder);
final IndividualResource item = itemsClient.get(itemId);
assertThat("Item status should be available",
item.getJson().getJsonObject("status").getString("name"), is("Available"));
}
@Test
void cannotCreateOpenLoanForUnknownRequestingUser() {
UUID loanId = UUID.randomUUID();
final UUID itemId = itemsFixture.basedUponSmallAngryPlanet().getId();
final UUID unknownUserId = UUID.randomUUID();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
final Response response = loansFixture.attemptToCreateLoan(new LoanBuilder()
.withId(loanId)
.withUserId(unknownUserId)
.withItemId(itemId)
.withLoanDate(loanDate)
.withDueDate(dueDate)
.open(),
UNPROCESSABLE_ENTITY);
assertThat(response.getJson(), hasErrorWith(allOf(
hasMessage("user is not found"),
hasUUIDParameter("userId", unknownUserId))));
}
@Test
void cannotCreateOpenLoanWithoutUserId() {
UUID loanId = UUID.randomUUID();
final UUID itemId = itemsFixture.basedUponSmallAngryPlanet().getId();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
final Response response = loansFixture.attemptToCreateLoan(new LoanBuilder()
.withId(loanId)
.withNoUserId()
.withItemId(itemId)
.withLoanDate(loanDate)
.withDueDate(dueDate)
.open(),
UNPROCESSABLE_ENTITY);
assertThat(format("Should not create loan: %s", response.getBody()),
response.getStatusCode(), is(UNPROCESSABLE_ENTITY));
assertThat(response.getJson(), hasErrorWith(allOf(
hasMessage("Open loan must have a user ID"),
hasNullParameter("userId"))));
}
@Test
void cannotCreateOpenLoanAtSpecificLocationWithoutUserId() {
UUID loanId = UUID.randomUUID();
final UUID itemId = itemsFixture.basedUponSmallAngryPlanet().getId();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
val loanBuilder = new LoanBuilder()
.withId(loanId)
.withNoUserId()
.withItemId(itemId)
.withLoanDate(loanDate)
.withDueDate(dueDate)
.open();
// Prepare loan
UUID userId = usersFixture.charlotte().getId();
loansFixture.createLoan(loanBuilder.withUserId(userId));
Response response = loansFixture.attemptToCreateLoanAtSpecificLocation(
loanId, loanBuilder);
assertThat(response.getJson(), hasErrorWith(allOf(
hasMessage("Open loan must have a user ID"),
hasNullParameter("userId"))));
}
@Test
void canCreateALoanWithSystemReturnDate() {
UUID id = UUID.randomUUID();
UUID itemId = itemsFixture.basedUponSmallAngryPlanet().getId();
UUID userId = usersFixture.charlotte().getId();
ZonedDateTime loanDate = ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC);
ZonedDateTime dueDate = ZonedDateTime.of(2017, 3, 29, 10, 23, 43, 0, UTC);
ZonedDateTime systemReturnDate = ZonedDateTime.of(2017, 4, 1, 12, 0, 0, 0, UTC);
IndividualResource response = loansFixture.createLoan(
new LoanBuilder()
.closed()
.withId(id)
.withUserId(userId)
.withItemId(itemId)
.withLoanDate(loanDate)
.withDueDate(dueDate)
.withSystemReturnDate(systemReturnDate));
JsonObject loan = response.getJson();
assertThat("systemReturnDate does not match",
loan.getString("systemReturnDate"), isEquivalentTo(systemReturnDate));
}
@Test
void cannotCheckOutAnItemTwice() {
IndividualResource smallAngryPlanet = itemsFixture.basedUponSmallAngryPlanet();
IndividualResource james = usersFixture.james();
IndividualResource jessica = usersFixture.jessica();
loansFixture.createLoan(smallAngryPlanet, james);
Response response = loansFixture.attemptToCreateLoan(smallAngryPlanet, jessica);
assertThat(response.getJson(), hasErrorWith(allOf(
hasMessage("Item is already checked out"),
hasUUIDParameter("itemId", smallAngryPlanet.getId()))));
}
@Test
void cannotCheckOutMissingItem() {
final IndividualResource missingItem = setupMissingItem(itemsFixture);
final IndividualResource steve = usersFixture.steve();
Response response = loansFixture.attemptToCreateLoan(missingItem, steve);
assertThat(response.getJson(), hasErrorWith(allOf(
hasMessageContaining("has the item status Missing"),
hasUUIDParameter("itemId", missingItem.getId()))));
}
@Test
void cannotCheckOutDeclaredLostItem() {
final IndividualResource declaredLostItem = itemsFixture.setupDeclaredLostItem();
final IndividualResource steve = usersFixture.steve();
Response response = loansFixture.attemptToCreateLoan(declaredLostItem, steve);
assertThat(response.getJson(), hasErrorWith(allOf(
hasMessageContaining("has the item status Declared lost"),
hasUUIDParameter("itemId", declaredLostItem.getId()))));
}
@Test
void cannotCreateLoanThatIsNotOpenOrClosed() {
IndividualResource smallAngryPlanet = itemsFixture.basedUponSmallAngryPlanet();
IndividualResource jessica = usersFixture.jessica();
final Response response = loansFixture.attemptToCreateLoan(new LoanBuilder()
.withStatus("Unknown Status")
.withItemId(smallAngryPlanet.getId())
.withUserId(jessica.getId()),
UNPROCESSABLE_ENTITY);
assertThat(response.getJson(), hasErrorWith(
hasMessage("Loan status must be \"Open\" or \"Closed\"")));
}
@Test
void canCreateALoanWithoutStatus() {
UUID id = UUID.randomUUID();
IndividualResource smallAngryPlanet = itemsFixture.basedUponSmallAngryPlanet(
builder -> builder
.withEnumeration("v.70:no.1-6")
.withChronology("1987:Jan.-June")
.withVolume("testVolume"));
UUID itemId = smallAngryPlanet.getId();
UUID userId = usersFixture.charlotte().getId();
IndividualResource response = loansFixture.createLoan(new LoanBuilder()
.withId(id)
.withUserId(userId)
.withItemId(itemId)
.withNoStatus());
JsonObject loan = response.getJson();
assertThat("status is not open",
loan.getJsonObject("status").getString("name"), is("Open"));
assertThat("action is not checkedout",
loan.getString("action"), is("checkedout"));
loanHasLoanPolicyProperties(response.getJson(),
loanPoliciesFixture.canCirculateRolling());
assertThat("title is taken from item",
loan.getJsonObject("item").containsKey("title"), is(true));
assertThat("barcode is taken from item",
loan.getJsonObject("item").containsKey("barcode"), is(true));
assertThat("has item status",
loan.getJsonObject("item").containsKey("status"), is(true));
assertThat("status is taken from item",
loan.getJsonObject("item").getJsonObject("status").getString("name"),
is("Checked out"));
assertThat("has item enumeration",
loan.getJsonObject("item").getString("enumeration"), is("v.70:no.1-6"));
assertThat("has item chronology",
loan.getJsonObject("item").getString("chronology"), is("1987:Jan.-June"));
assertThat("has item volume",
loan.getJsonObject("item").getString("volume"), is("testVolume"));
JsonObject item = itemsClient.getById(itemId).getJson();
assertThat("item status is not checked out",
item.getJsonObject("status").getString("name"), is("Checked out"));
assertThat("has item enumeration",
item.getString("enumeration"), is("v.70:no.1-6"));
assertThat("has item chronology",
item.getString("chronology"), is("1987:Jan.-June"));
assertThat("has item volume",
item.getString("volume"), is("testVolume"));
assertThat("item status snapshot in storage is not checked out",
loansStorageClient.getById(id).getJson().getString("itemStatus"),
is("Checked out"));
}
@Test
void creatingAReturnedLoanDoesNotChangeItemStatus() {
UUID id = UUID.randomUUID();
IndividualResource smallAngryPlanet = itemsFixture.basedUponSmallAngryPlanet(
builder -> builder
.withEnumeration("v.70:no.1-6")
.withChronology("1987:Jan.-June")
.withVolume("testVolume"));
UUID itemId = smallAngryPlanet.getId();
UUID userId = usersFixture.charlotte().getId();
IndividualResource response = loansFixture.createLoan(new LoanBuilder()
.withId(id)
.withUserId(userId)
.withItemId(itemId)
.withLoanDate(ZonedDateTime.of(2017, 2, 27, 10, 23, 43, 0, UTC))
.withReturnDate(ZonedDateTime.of(2017, 3, 15, 11, 14, 36, 0, UTC))
.withStatus("Closed"));
JsonObject loan = response.getJson();
assertThat("id does not match",
loan.getString("id"), is(id.toString()));
assertThat("user id does not match",
loan.getString("userId"), is(userId.toString()));
assertThat("item id does not match",
loan.getString("itemId"), is(itemId.toString()));
assertThat("loan date does not match",
loan.getString("loanDate"), is("2017-02-27T10:23:43.000Z"));
assertThat("status is not closed",
loan.getJsonObject("status").getString("name"), is("Closed"));
assertThat("action is not checkedin",
loan.getString("action"), is("checkedin"));
assertThat("Should not have snapshot of item status, as current status is included",
loan.containsKey("itemStatus"), is(false));
assertThat("has item enumeration",
loan.getJsonObject("item").getString("enumeration"), is("v.70:no.1-6"));
assertThat("has item chronology",
loan.getJsonObject("item").getString("chronology"), is("1987:Jan.-June"));
assertThat("has item volume",
loan.getJsonObject("item").getString("volume"), is("testVolume"));
JsonObject item = itemsClient.getById(itemId).getJson();
assertThat("item status is not available",
item.getJsonObject("status").getString("name"), is("Available"));
assertThat("has item enumeration",
item.getString("enumeration"), is("v.70:no.1-6"));
assertThat("has item chronology",
item.getString("chronology"), is("1987:Jan.-June"));
assertThat("has item volume",
item.getString("volume"), is("testVolume"));
assertThat("item status snapshot in storage is not available",
loansStorageClient.getById(id).getJson().getString("itemStatus"),
is("Available"));
}
@Test
void canGetALoanById() {
UUID id = UUID.randomUUID();
UUID itemId = itemsFixture.basedUponSmallAngryPlanet(
itemBuilder -> itemBuilder
.withBarcode("036000291452")
.withEnumeration("v.70:no.1-6")
.withChronology("1987:Jan.-June")
.withVolume("testVolume")
.withCopyNumber("cp.1"))
.getId();
val user = usersFixture.charlotte();
UUID userId = user.getId();
ZonedDateTime dueDate = ZonedDateTime.of(2016, 11, 15, 8, 26, 53, 0, UTC);