MODINV-1095: kafka.KafkaContainer, apache/kafka-native:3.8.0#776
Merged
julianladisch merged 2 commits intomasterfrom Oct 16, 2024
Merged
MODINV-1095: kafka.KafkaContainer, apache/kafka-native:3.8.0#776julianladisch merged 2 commits intomasterfrom
julianladisch merged 2 commits intomasterfrom
Conversation
Upgrade from deprecated org.testcontainers.containers.KafkaContainer to org.testcontainers.kafka.KafkaContainer, see https://java.testcontainers.org/modules/kafka/ Upgrade from confluentinc/cp-kafka 7.0.3 to apache/kafka-native:3.8.0, see https://hub.docker.com/r/apache/kafka-native This reduces the build time by 8 seconds on GitHub Actions (ubuntu-latest, 2 cores of AMD EPYC 7763 64-Core Processor) and the Kafka image size from 381 MB to 47 MB.
Aliaksandr-Fedasiuk
approved these changes
Oct 14, 2024
RuslanLavrov
approved these changes
Oct 15, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade from deprecated org.testcontainers.containers.KafkaContainer to org.testcontainers.kafka.KafkaContainer, see https://java.testcontainers.org/modules/kafka/
Upgrade from confluentinc/cp-kafka 7.0.3 to apache/kafka-native:3.8.0, see https://hub.docker.com/r/apache/kafka-native
This reduces the build time by 8 seconds on GitHub Actions (ubuntu-latest, 2 cores of AMD EPYC 7763 64-Core Processor) and the Kafka image size from 381 MB to 47 MB.
If the build fails with NoSuchMethodError about FileTimes.toUnixTime later then downgrade commons-compress to 1.26.2, see testcontainers/testcontainers-java#8354 and https://github.com/folio-org/mod-users/pull/373/files