MODWRKFLOW-69: Support checksums, created on date, and updated on date.#160
Merged
Conversation
Add checksum, created on, and updated on fields. Provide default time stamps. Provide interfaces for handling added fields. Update unit tests.
…vate/deactivate. A likely better design is to just get the success/failure and control the model locally. This would require just updating the desired fields. However, doing this would require more massive changes.
rmathew1011
reviewed
Jul 13, 2026
| @Column(nullable = false, unique = true) | ||
| private String name; | ||
|
|
||
| @OneToMany |
Contributor
There was a problem hiding this comment.
SonarQube warning present here in this annotation OnetoMany - is not fully defined -either mappedBy or @JoinColumn is missing.
Contributor
Author
There was a problem hiding this comment.
Yep, probably need something like:
@OneToMany(mappedBy = "workflow")The oneToMany isn't new code and this change set does not change that code.
We probably should create an issue and address this separately as it is out of scope and has potential for breaking changes.
SonarQube incorrectly believes that the OneToMany is new code.
rmathew1011
approved these changes
Jul 13, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves MODWRKFLOW-69 .
Add checksum, created on, and updated on fields.
Provide default time stamps.
Provide interfaces for handling added fields.
Update unit tests.