RMB-1046: Avoid regex in .replaceAll(" +[*]", "")

https://folio-org.atlassian.net/browse/RMB-1046

Sonar reports:

https://sonarcloud.io/project/security_hotspots?id=org.folio%3Araml-module-builder&hotspots=AX9uQp8Uu74XD50_RGf1

> Make sure the regex used here, which is vulnerable to polynomial runtime due to backtracking, cannot lead to denial of service.
>
> Using slow regular expressions is security-sensitive
>
> java:S5852 https://sonarcloud.io/organizations/folio-org/rules?open=java%3AS5852&rule_key=java%3AS5852

Code:

https://github.com/folio-org/raml-module-builder/blob/v35.4.0/cql2pgjson/src/main/java/org/folio/cql2pgjson/CQL2PgJSON.java#L831

> .replaceAll(" +[*]", "")

Task:

Use `.replace(" *", " ")` instead.

This completely avoids using a regex.

Author: julianladisch

cql2pgjson/src/main/java/org/folio/cql2pgjson/CQL2PgJSON.java

@@ -828,7 +828,7 @@ private String queryByFt(String index, DbIndex dbIndex, IndexTextAndJsonValues v
     }
 
     // Clean the term. Remove stand-alone ' *', not valid word.
-    String term = node.getTerm().replaceAll(" +[*]", "").trim();
+    String term = node.getTerm().replace(" *", " ").trim();
     Index schemaIndex = null;
     if (targetTable != null) {
       schemaIndex = DbSchemaUtils.getIndex(index, targetTable.getFullTextIndex());

cql2pgjson/src/test/java/org/folio/cql2pgjson/CQL2PgJSONTest.java

@@ -936,6 +936,8 @@ public void idMatch(String testcase) {
     "name == \"Lea Long\"           # Lea Long",
     "name <> \"Lea Long\"           # Jo Jane; Ka Keller",
     "name = \"Lea *\"               # Lea Long", // Loose '*' should be ignored
+    "name = \"Lea * Long\"          # Lea Long",
+    "name = \"Lea  *  Long\"        # Lea Long",
     "name = \"*\"                   # Jo Jane; Ka Keller; Lea Long", // special case
     "name = \"Le* Lo*\"             # Lea Long",
     "name = \" * * \"               # Jo Jane; Ka Keller; Lea Long",