fix(cli): enable file watcher when attaching to external sessions#305
Open
arbrandes wants to merge 1 commit intofolke:mainfrom
Open
fix(cli): enable file watcher when attaching to external sessions#305arbrandes wants to merge 1 commit intofolke:mainfrom
arbrandes wants to merge 1 commit intofolke:mainfrom
Conversation
`watch.enable()` was only called from `terminal.lua` when a Neovim terminal job started, so external tmux panes (`mux.create = "split"` or `"window"`) never triggered `:checktime` on file changes. Enable the watcher in the shared session attach path so all backends benefit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
watch.enable()was only called fromterminal.luawhen a Neovim terminal job started, so external tmux panes (mux.create = "split"or"window") never triggered:checktimeon file changes — files edited by the CLI tool wouldn't auto-reload in Neovim. Callingwatch.enable()in the shared session attach path makes all backends behave the same; the call is idempotent, so the existing terminal invocation is unaffected.