perf(util): small perf optims#961
Open
Kalmaegi wants to merge 1 commit into
Open
Conversation
Contributor
|
This PR is stale because it has been open 30 days with no activity. |
iSplasher
added a commit
to isplasher-forks/which-key.nvim
that referenced
this pull request
Jun 20, 2025
iSplasher
added a commit
to isplasher-forks/which-key.nvim
that referenced
this pull request
Jun 20, 2025
|
Not stale |
Contributor
|
This PR is stale because it has been open 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there are two similar caching patterns in the codebase with slightly different implementations. Specifically, the M.t function uses a short-circuit evaluation pattern while M.norm uses an explicit if-check:
I think it might be beneficial to unify these patterns for better code consistency. I'm not sure if this small change is worth a PR, I just wanted to contribute a small improvement to this excellent plugin.