added check for lexicographical ordering of keys when decoding dictionaries in Bento.Parser#31
Open
ifoo wants to merge 1 commit into
Open
added check for lexicographical ordering of keys when decoding dictionaries in Bento.Parser#31ifoo wants to merge 1 commit into
ifoo wants to merge 1 commit into
Conversation
…naries in Bento.Parser
Author
|
I'm not sure if you want to add this, as it might break parsing of malformed dictionaries. On the one hand, dictionary keys that are not ordered are clearly defined as invalid in the spec. On the other hand, we might want the parser to be liberal. Best case would be the have an option (like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.