fix(dropdown): double hide transition breaks upward out#2818
Merged
lubber-de merged 1 commit intofomantic:developfrom Jun 11, 2023
Merged
fix(dropdown): double hide transition breaks upward out#2818lubber-de merged 1 commit intofomantic:developfrom
lubber-de merged 1 commit intofomantic:developfrom
Conversation
lubber-de
added
type/bug
This was referenced Jun 9, 2023
lubber-de
removed
the
state/awaiting-reviews
lubber-de
added
lang/javascript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a dropdown hides, the transition gets called twice messing up with upward menus and underlaying menu transparency.
This is because submenu hiding needs to be called separately (invented by #2331 ) , but in case a select is used the submenu is the dropdown itself, so it should not be (hide) animated again when it is already (hide) animating
Testcase
https://jsfiddle.net/lubber/Ld624p5m/
Closes
#2663
Replaces
#2777