-
-
Notifications
You must be signed in to change notification settings - Fork 337
feat(dropdown): allow editing of added items #3247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BrianJavier99
wants to merge
13
commits into
fomantic:develop
Choose a base branch
from
BrianJavier99:feat_fomantic_3232
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b54cb64
feat(dropdown): allow editing of added items
BrianJavier99 2b58ddb
Remove item if string is empty
BrianJavier99 aeaa5b5
Move style updates to dropdown.less
BrianJavier99 11f7fdd
remove margin variable
BrianJavier99 2053cfc
Limit editable labels to allowAdditions === true and improve editing …
BrianJavier99 adb36f0
Properly update value of dropdown's hidden menu
BrianJavier99 7f4cb4a
Prevent adding new item when editing an existing one
BrianJavier99 d7d6830
Merge branch 'develop' into feat_fomantic_3232
BrianJavier99 9c30252
Add checking if edited value matches with existing item in menu
BrianJavier99 79c41da
Also add "active" class to the menu item added by editing
BrianJavier99 42910b3
Fix issues spotted by CodeQL
BrianJavier99 c901c18
Fix linting issues detected by eslint
BrianJavier99 d1f7f1a
Fix lint issues in less file
BrianJavier99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.