Skip to content

Add back lost filter in compute_item_type_rotations #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fontanf merged 1 commit into from
Apr 19, 2026
Merged

Add back lost filter in compute_item_type_rotations #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/irregular/rotations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,11 +398,18 @@ std::vector<std::vector<std::vector<ItemTypeRotation>>> packingsolver::irregular
std::vector<ShapesByDimsMap> bin_shapes_by_dims(instance.number_of_item_types());

auto add_if_new_for_bin = [&](ItemTypeId item_type_id, Angle angle, bool mirror) {
const ItemType& item_type = instance.item_type(item_type_id);
const std::vector<Point>& hull_points = item_types_convex_hull_points[item_type_id];
for (const ItemTypeRotation& r: bin_output[item_type_id]) {
if (r.mirror != mirror)
continue;
Angle diff = std::abs(angle - r.angle);
if (diff < 5 || diff > 355)
return;
}

// Compute the AABB of the transformed convex hull to get (x_min, y_min)
// for normalizing the shape position.
const ItemType& item_type = instance.item_type(item_type_id);
const std::vector<Point>& hull_points = item_types_convex_hull_points[item_type_id];
double cos_a = std::cos(angle * M_PI / 180.0);
double sin_a = std::sin(angle * M_PI / 180.0);
LengthDbl x_min_t = +std::numeric_limits<LengthDbl>::infinity();
Expand Down
Loading