Skip to content

Commit 0c9a8b8

Browse files
fix(test): correct MockK static mock pattern for OAuth2.exchangeCode
TokenErrorResponse.error and .errorDescription are public Java fields, not methods. MockK's every { } block only intercepts method calls, so using every { mock.error } returns value triggers "Missing mocked calls inside every { ... } block". Fix by directly assigning the fields on the relaxed mock instance instead.
1 parent 5cecb66 commit 0c9a8b8

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/auth/LoginActivityAuthErrorTest.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ class LoginActivityAuthErrorTest {
8888
@Test
8989
fun onAuthFlowError_givenClientBlocked_broadcastsWithCorrectExtras() {
9090
val tokenErrorResponse = mockk<OAuth2.TokenErrorResponse>(relaxed = true)
91-
every { tokenErrorResponse.error } returns CLIENT_BLOCKED_ERROR
92-
every { tokenErrorResponse.errorDescription } returns "App is blocked by admin"
91+
tokenErrorResponse.error = CLIENT_BLOCKED_ERROR
92+
tokenErrorResponse.errorDescription = "App is blocked by admin"
9393
val oauthException = OAuthFailedException(tokenErrorResponse, 403)
9494

9595
every {
@@ -139,8 +139,8 @@ class LoginActivityAuthErrorTest {
139139
@Test
140140
fun onAuthFlowError_givenClientBlocked_showsAppBlockedToast() {
141141
val tokenErrorResponse = mockk<OAuth2.TokenErrorResponse>(relaxed = true)
142-
every { tokenErrorResponse.error } returns CLIENT_BLOCKED_ERROR
143-
every { tokenErrorResponse.errorDescription } returns "App is blocked"
142+
tokenErrorResponse.error = CLIENT_BLOCKED_ERROR
143+
tokenErrorResponse.errorDescription = "App is blocked"
144144
val oauthException = OAuthFailedException(tokenErrorResponse, 403)
145145

146146
every {
@@ -176,8 +176,8 @@ class LoginActivityAuthErrorTest {
176176
@Test
177177
fun onAuthFlowError_givenGenericOAuthError_broadcastsWithCorrectExtras() {
178178
val tokenErrorResponse = mockk<OAuth2.TokenErrorResponse>(relaxed = true)
179-
every { tokenErrorResponse.error } returns "invalid_grant"
180-
every { tokenErrorResponse.errorDescription } returns "Expired authorization code"
179+
tokenErrorResponse.error = "invalid_grant"
180+
tokenErrorResponse.errorDescription = "Expired authorization code"
181181
val oauthException = OAuthFailedException(tokenErrorResponse, 400)
182182

183183
every {

libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/auth/LoginViewModelMockTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -802,8 +802,8 @@ class LoginViewModelMockTest {
802802
mockkStatic(OAuth2::class)
803803

804804
val tokenErrorResponse = mockk<OAuth2.TokenErrorResponse>(relaxed = true)
805-
every { tokenErrorResponse.error } returns OAuth2.CLIENT_BLOCKED_ERROR
806-
every { tokenErrorResponse.errorDescription } returns "App is blocked"
805+
tokenErrorResponse.error = OAuth2.CLIENT_BLOCKED_ERROR
806+
tokenErrorResponse.errorDescription = "App is blocked"
807807
val oauthException = OAuth2.OAuthFailedException(tokenErrorResponse, 403)
808808

809809
every {
@@ -863,8 +863,8 @@ class LoginViewModelMockTest {
863863
mockkStatic(OAuth2::class)
864864

865865
val tokenErrorResponse = mockk<OAuth2.TokenErrorResponse>(relaxed = true)
866-
every { tokenErrorResponse.error } returns "invalid_grant"
867-
every { tokenErrorResponse.errorDescription } returns "Expired authorization code"
866+
tokenErrorResponse.error = "invalid_grant"
867+
tokenErrorResponse.errorDescription = "Expired authorization code"
868868
val oauthException = OAuth2.OAuthFailedException(tokenErrorResponse, 400)
869869

870870
every {

0 commit comments

Comments
 (0)