Make LegacyAuthenticatorService public to avoid error log lines. Make upgrade step public. (#2840)

Author: brandonpage

libs/SalesforceSDK/src/com/salesforce/androidsdk/app/SalesforceSDKUpgradeManager.java

@@ -314,11 +314,14 @@ private void updateFromBefore13_0_2() {
         PushMessaging.setReRegistrationRequested(true);
     }
 
-    /*
+    /**
      *  Migrate any accounts with account_type "com.salesforce.androidsdk" to a unique value.
-     *  TODO: Remove this in Mobile SDK 15.0
+     *
+     *  @deprecated Will be removed in Mobile SDK 15.0.0.
      */
-    private void migrateAccountType() {
+    @Deprecated
+    @SuppressWarnings("DeprecatedIsStillUsed")
+    public void migrateAccountType() {
         final String LEGACY_ACCOUNT_TYPE = "com.salesforce.androidsdk";
         if (SalesforceSDKManager.getInstance().getAccountType().equals(LEGACY_ACCOUNT_TYPE)) {
             SalesforceSDKLogger.e(TAG, "No app specific account type found.  To ensure users " +

libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/LegacyAuthenticatorService.java

@@ -26,4 +26,11 @@
  */
 package com.salesforce.androidsdk.auth;
 
-class LegacyAuthenticatorService extends AuthenticatorService { }
+/**
+ * Android requires service classes to be public.  Do not use.
+ *
+ * @deprecated This class is used to migrate legacy accounts and will be removed in Mobile SDK 15.0.0.
+ */
+@Deprecated
+@SuppressWarnings("DeprecatedIsStillUsed")
+public final class LegacyAuthenticatorService extends AuthenticatorService { }