Skip to content

Add dpop to pull_request_target branches allowlist (temporary)#2950

Merged
wmathurin merged 1 commit into
forcedotcom:devfrom
wmathurin:enable-ci-for-dpop-branch
Jul 1, 2026
Merged

Add dpop to pull_request_target branches allowlist (temporary)#2950
wmathurin merged 1 commit into
forcedotcom:devfrom
wmathurin:enable-ci-for-dpop-branch

Conversation

@wmathurin

Copy link
Copy Markdown
Contributor

Summary

  • Adds dpop to the branches list under the pull_request_target trigger in .github/workflows/pr.yaml
  • GitHub evaluates pull_request_target against the default branch (dev) copy of the workflow, so the dpop branch's copy alone is not sufficient to trigger CI for PRs targeting dpop
  • This is a temporary entry — remove once DPoP merges back to dev

Why now

Three more Android PRs in the DPoP rollout are queued to target dpop after #2949:

  • W-22697878 (nonce support)
  • W-22698013 (automated UI tests)
  • W-23192897 (dev-info-screen DPoP state)

Without this, none of them get Firebase Test Lab, codecov, or Danger. The Phase 3 PR (#2949) already shipped two red serialization tests that per-PR CI would have caught.

Test plan

  • Verify that the next PR targeting dpop shows the Pull Request workflow in its checks list
  • Remove the dpop entry from this list when DPoP merges back to dev

Temporary entry so PRs in the multi-PR DPoP rollout (targeting the dpop
integration branch) trigger the Pull Request CI workflow. GitHub evaluates
pull_request_target against the default branch (dev) copy of the workflow,
so the dpop branch's copy alone is not sufficient.

Remove this entry once DPoP merges back to dev.

@JohnsonEricAtSalesforce JohnsonEricAtSalesforce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This response was generated by an AI agent on behalf of @JohnsonEricAtSalesforce.

@wmathurin wmathurin merged commit 28d4593 into forcedotcom:dev Jul 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants