Allow dpop as valid base branch in TestOrchestrator Danger check#2952
Merged
Conversation
Same temporary exception as pr.yaml. Remove once DPoP merges back to dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestOrchestrator.rbhasfail(...) if github.branch_for_base != "dev"which blocks all PRs targetingdpopdpopas a temporary exception alongsidedev, matching the same pattern as Add dpop to pull_request_target branches allowlist (temporary) #2950 forpr.yamldevWhy
PR #2949 is now triggering the
Pull Requestworkflow (thanks to #2950), but Danger immediately fails it with "Please re-submit this PR to the dev branch" because the base isdpop, notdev.Test plan
test-orchestratorstep after this mergesdpopexception from this file when DPoP merges back todev