Update nightly schedule to Tue/Thu at 9:30 PM PT and fix security issues#306
Merged
Merged
Conversation
|
||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #306 +/- ##
=======================================
Coverage 62.62% 62.62%
=======================================
Files 21 21
Lines 1699 1699
=======================================
Hits 1064 1064
Misses 635 635
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
||||||||||||||
wmathurin
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements W-22712082 — Cleanup CI for all Repos.
Schedule change: Nightly tests now run Tue/Thu at 9:30 PM PT (
30 5 * * 3,5UTC), up from Wed-only. Catches regressions twice a week instead of once. Alternates with the ReactNative nightly's Mon/Wed/Fri 9:30 PM slot.Security hardening: All workflows updated to follow the GitHub Actions injection-prevention best practices:
permissions:block added to every workflow:contents: readbaseline,pull-requests: writefor the test reusable (it usesmikepenz/action-junit-reportwithcomment: true).secrets: inheritreplaced with explicit secret pass-through; reusable test workflow declaresTEST_CREDENTIALSandCODECOV_TOKENinon: workflow_call: secrets:.${{ ... }}shell interpolation inrun:blocks refactored toenv:variables with quoted shell expansions (only theParse test resultsstep in the reusable test workflow had any).pull_request_targetretained with# zizmor: ignore[dangerous-triggers]and inline comment documenting the Member Check mitigation.actions/checkoutsteps setwith: persist-credentials: false.After this change,
zizmor --offlinereports 0 High-confidence findings across all four CI workflows.Test plan
python3 yaml.safe_load,actionlint -shellcheck=,zizmor --offline. All clean.brandonpage/SalesforceMobileSDK-iOS-Hybrid#2) targeting the samecleanup-ci-w22712082branch as this PR. The test PR triggers the new workflows against a real source change inSalesforceFileLogger. No regressions observed — see linked PR for run details.permissions:blocks match the team's expected privilege levels for each workflow.🤖 Generated with Claude Code