Skip to content

feat(W-23159740): use per-user UA string in SFHybridViewController#314

Open
wmathurin wants to merge 1 commit into
forcedotcom:devfrom
wmathurin:W-21167151-feature-flags-per-user
Open

feat(W-23159740): use per-user UA string in SFHybridViewController#314
wmathurin wants to merge 1 commit into
forcedotcom:devfrom
wmathurin:W-21167151-feature-flags-per-user

Conversation

@wmathurin

Copy link
Copy Markdown
Contributor

Summary

  • SFHybridViewController.m: passes currentUser to userAgentString:qualifier:forUser: so per-user feature flags are included in the hybrid WebView User-Agent string

GUS Stories

  • W-23159740 (iOS per-user feature flags)
  • W-21167151 (spike)

Dependencies

Test plan

  • Code review — single-method simplification
  • Integration tests (require sandbox credentials — run in CI)

Passes current user to userAgentString:qualifier:forUser: so per-user
feature flags appear in the User-Agent for hybrid views.
@github-actions

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
SalesforceFileLogger iOS ^26 Test Results15 ran15 ✅
TestResult
No test annotations available

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.51%. Comparing base (aeb58bd) to head (95e2382).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #314      +/-   ##
==========================================
- Coverage   62.62%   62.51%   -0.12%     
==========================================
  Files          21       21              
  Lines        1699     1694       -5     
==========================================
- Hits         1064     1059       -5     
  Misses        635      635              
Flag Coverage Δ
SalesforceFileLogger 70.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lesforceHybridSDK/Classes/SFHybridViewController.m 40.95% <ø> (-0.93%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wmathurin

Copy link
Copy Markdown
Contributor Author

NB: Once the iOS PR forcedotcom/SalesforceMobileSDK-iOS#4086 is merged, I will update the submodule here and the tests should build and pass again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants