Merge pull request #3751 from bbirman/analytics-warnings

Fix analytics warnings

Author: bbirman

libs/SalesforceAnalytics/SalesforceAnalytics/Classes/Store/SFSDKEventStoreManager.h

@@ -71,7 +71,7 @@ typedef NSData * _Nullable (^ _Nullable DataDecryptorBlock)(NSData * _Nullable d
  *
  * @return List of event files.
  */
-- (NSArray<SFSDKInstrumentationEvent *> *) eventFiles;
+- (nullable NSArray<NSString *> *)eventFiles;
 
 /**
  * Returns a specific event stored on the filesystem.

libs/SalesforceAnalytics/SalesforceAnalytics/Classes/Store/SFSDKEventStoreManager.m

@@ -120,7 +120,7 @@ - (void) storeEvents:(NSArray<SFSDKInstrumentationEvent *> *) events {
     }
 }
 
-- (NSArray<SFSDKInstrumentationEvent *> *) eventFiles {
+- (NSArray<NSString *> *)eventFiles {
     return [[NSFileManager defaultManager] contentsOfDirectoryAtPath:self.storeDirectory error:nil];
 }
 

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Analytics/SFSDKSalesforceAnalyticsManager.m

@@ -219,7 +219,7 @@ - (void) publishAllEvents {
         } else {
             NSArray *eventFiles = [self.eventStoreManager eventFiles];
             SInt32 i = 0;
-            SInt32 remainingEvents = eventFiles.count;
+            NSUInteger remainingEvents = eventFiles.count;
 
             while (i < eventFiles.count) {
                 NSArray *subEvents = [eventFiles subarrayWithRange:NSMakeRange(i, MIN(kBatchProcessCount, remainingEvents))];