Skip to content

feat: @W-22259678@ changes with clt ref to mosaic rendition guidance#190

Merged
hsinghbisht-sfdc merged 7 commits intoforcedotcom:developfrom
sowmya-sriram:inline-mosaic-poc
May 5, 2026
Merged

feat: @W-22259678@ changes with clt ref to mosaic rendition guidance#190
hsinghbisht-sfdc merged 7 commits intoforcedotcom:developfrom
sowmya-sriram:inline-mosaic-poc

Conversation

@sowmya-sriram
Copy link
Copy Markdown
Contributor

@sowmya-sriram sowmya-sriram commented Apr 10, 2026

References: Contributing guide · Skill authoring guide · Agent Skills spec

@W-22259678@

What changed

  1. Created widget-rendition.md as a reference for generating-custom-lightning-type skill
  2. Update generating-custom-lightning-type skill to use above reference
  3. Deleted generating-fragment skill

Why

Support widget rendition for CLTs

Notes


Skills

Manual checklist

Description quality

  • Describes what the skill does and the expected output
  • Includes relevant Salesforce domain keywords (Apex, LWC, SOQL, metadata types, etc.)
  • Trigger phrases are specific enough for Vibes to select this skill reliably

Instructions

  • Clear goal statement
  • Step-by-step workflow
  • Validation rules for generated output
  • Defined output / artifact

Context efficiency

  • Core instructions are concise — supporting material lives in templates/, examples/, or docs/ subdirectories
  • No unnecessary background explanation in the body

Automated checks

Enforced by CI (npm run validate:skills) per the Agent Skills spec:

  • Directory is one level deep, named in kebab-case (max 64 chars), contains SKILL.md
  • Frontmatter name matches directory name; description is present, ≥ 20 words, ≤ 1024 characters, and includes trigger language
  • Body is non-empty and under 500 lines
  • Name uses gerund form ⚠ (warning — does not block merge)

@sowmya-sriram sowmya-sriram changed the title changes with clt ref to mosaic rendition changes with clt ref to mosaic rendition guidance Apr 10, 2026
@sowmya-sriram sowmya-sriram changed the base branch from main to develop April 20, 2026 07:55
@sowmya-sriram sowmya-sriram marked this pull request as ready for review April 20, 2026 08:01
@sowmya-sriram sowmya-sriram changed the title changes with clt ref to mosaic rendition guidance @W-22134404 changes with clt ref to mosaic rendition guidance Apr 20, 2026
@hsinghbisht-sfdc hsinghbisht-sfdc force-pushed the develop branch 2 times, most recently from 88e49f5 to 2d508c8 Compare April 21, 2026 09:13
@sowmya-sriram sowmya-sriram changed the title @W-22134404 changes with clt ref to mosaic rendition guidance feat: @W-22134404@ changes with clt ref to mosaic rendition guidance Apr 23, 2026
Copy link
Copy Markdown
Contributor

@manoj-dasari manoj-dasari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -1,6 +1,8 @@
---
name: generating-custom-lightning-type
description: "Use this skill when users need to create Custom Lightning Types (CLTs) for Einstein Agent actions or structured input/output schemas. Trigger when users mention CLT, Custom Lightning Types, JSON schemas for agents, type definitions, lightning__objectType, or editor/renderer configurations. This is complex - always use this skill for CLT work."
description: "Use this skill when users need to create Custom Lightning Types (CLTs) for Einstein Agent actions or structured input/output schemas. Trigger when users mention CLT, Custom Lightning Types,
Custom Lightning Types (CLTs) with widget/mosaic/fragment rendition/renderer, JSON schemas for agents, type definitions, lightning__objectType, or editor/renderer configurations. When widget renditions are requested, you
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have some extra new line characters in the description, Can you please write the description together.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

description: "Use this skill when users need to create Custom Lightning Types (CLTs) for Einstein Agent actions or structured input/output schemas. Trigger when users mention CLT, Custom Lightning Types, JSON schemas for agents, type definitions, lightning__objectType, or editor/renderer configurations. This is complex - always use this skill for CLT work."
description: "Use this skill when users need to create Custom Lightning Types (CLTs) for Einstein Agent actions or structured input/output schemas. Trigger when users mention CLT, Custom Lightning Types,
Custom Lightning Types (CLTs) with widget/mosaic/fragment rendition/renderer, JSON schemas for agents, type definitions, lightning__objectType, or editor/renderer configurations. When widget renditions are requested, you
MUST first read the widget-rendition.md reference file in this skill's references/ directory and follow its complete workflow. This is complex - always use this skill for CLT work."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you expecting to read widget-rendition.md before executing this Skill?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it fetches generating-custom-lightning-type skill and reads widget-rendition.md when the user prompt requests for widget rendition. It would be fine to read widget-rendition.md at the stage when it is actually required but I observed that AFV was not picking it up if not enforced in the description.

@@ -57,26 +60,26 @@ Custom Lightning Types (CLTs) are JSON Schema-based type definitions used by the

## Primitive Types & Constraints
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Priortize to use progressive disclosure and you can put this inside /assets

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsinghbisht-sfdc This is owned by TSE team. cc: @manoj-dasari

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this in an upcoming PR. Creating a backlog WI to track.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W-22279874

- Run a final schema sanity check before deploy: valid `lightning:type` names, required fields present, and no disallowed keywords.
- Deploy the bundle using your org's standard metadata deployment flow (e.g. Salesforce CLI or IDE). The MCP client or tooling in use should provide or integrate with the appropriate deploy/retrieve commands for Lightning Type bundles.
- Validate incrementally: if deployment fails, remove disallowed keywords first (especially `examples`, `items`, nested `lightning:type`).
- Deploy the bundle using your org's standard metadata deployment flow (e.g. Salesforce CLI or IDE). The MCP client or tooling in use should provide or integrate with the appropriate deploy/retrieve commands for Lightning Type bundles.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not instruct Deploy in the Skills.
This instruction is outside the boundary of Skills.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is owned by TSE team.
cc: @manoj-dasari

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this in an upcoming PR. Creating a backlog WI to track.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W-22279874

@hsinghbisht-sfdc
Copy link
Copy Markdown
Contributor

@sowmya-sriram you have merge conflicts.

@sowmya-sriram
Copy link
Copy Markdown
Contributor Author

@sowmya-sriram you have merge conflicts.

@hsinghbisht-sfdc resolved merge conflicts, please take a look.

@sowmya-sriram sowmya-sriram changed the title feat: @W-22134404@ changes with clt ref to mosaic rendition guidance feat: @W-22259678@ changes with clt ref to mosaic rendition guidance May 5, 2026
@hsinghbisht-sfdc hsinghbisht-sfdc merged commit 5d33d63 into forcedotcom:develop May 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants