feat: @W-22259678@ changes with clt ref to mosaic rendition guidance#190
Conversation
88e49f5 to
2d508c8
Compare
2d508c8 to
119dc66
Compare
| @@ -1,6 +1,8 @@ | |||
| --- | |||
| name: generating-custom-lightning-type | |||
| description: "Use this skill when users need to create Custom Lightning Types (CLTs) for Einstein Agent actions or structured input/output schemas. Trigger when users mention CLT, Custom Lightning Types, JSON schemas for agents, type definitions, lightning__objectType, or editor/renderer configurations. This is complex - always use this skill for CLT work." | |||
| description: "Use this skill when users need to create Custom Lightning Types (CLTs) for Einstein Agent actions or structured input/output schemas. Trigger when users mention CLT, Custom Lightning Types, | |||
| Custom Lightning Types (CLTs) with widget/mosaic/fragment rendition/renderer, JSON schemas for agents, type definitions, lightning__objectType, or editor/renderer configurations. When widget renditions are requested, you | |||
There was a problem hiding this comment.
Looks like you have some extra new line characters in the description, Can you please write the description together.
| description: "Use this skill when users need to create Custom Lightning Types (CLTs) for Einstein Agent actions or structured input/output schemas. Trigger when users mention CLT, Custom Lightning Types, JSON schemas for agents, type definitions, lightning__objectType, or editor/renderer configurations. This is complex - always use this skill for CLT work." | ||
| description: "Use this skill when users need to create Custom Lightning Types (CLTs) for Einstein Agent actions or structured input/output schemas. Trigger when users mention CLT, Custom Lightning Types, | ||
| Custom Lightning Types (CLTs) with widget/mosaic/fragment rendition/renderer, JSON schemas for agents, type definitions, lightning__objectType, or editor/renderer configurations. When widget renditions are requested, you | ||
| MUST first read the widget-rendition.md reference file in this skill's references/ directory and follow its complete workflow. This is complex - always use this skill for CLT work." |
There was a problem hiding this comment.
Are you expecting to read widget-rendition.md before executing this Skill?
There was a problem hiding this comment.
Yes, it fetches generating-custom-lightning-type skill and reads widget-rendition.md when the user prompt requests for widget rendition. It would be fine to read widget-rendition.md at the stage when it is actually required but I observed that AFV was not picking it up if not enforced in the description.
| @@ -57,26 +60,26 @@ Custom Lightning Types (CLTs) are JSON Schema-based type definitions used by the | |||
|
|
|||
| ## Primitive Types & Constraints | |||
There was a problem hiding this comment.
Priortize to use progressive disclosure and you can put this inside /assets
There was a problem hiding this comment.
@hsinghbisht-sfdc This is owned by TSE team. cc: @manoj-dasari
There was a problem hiding this comment.
Will fix this in an upcoming PR. Creating a backlog WI to track.
| - Run a final schema sanity check before deploy: valid `lightning:type` names, required fields present, and no disallowed keywords. | ||
| - Deploy the bundle using your org's standard metadata deployment flow (e.g. Salesforce CLI or IDE). The MCP client or tooling in use should provide or integrate with the appropriate deploy/retrieve commands for Lightning Type bundles. | ||
| - Validate incrementally: if deployment fails, remove disallowed keywords first (especially `examples`, `items`, nested `lightning:type`). | ||
| - Deploy the bundle using your org's standard metadata deployment flow (e.g. Salesforce CLI or IDE). The MCP client or tooling in use should provide or integrate with the appropriate deploy/retrieve commands for Lightning Type bundles. |
There was a problem hiding this comment.
Please do not instruct Deploy in the Skills.
This instruction is outside the boundary of Skills.
There was a problem hiding this comment.
This is owned by TSE team.
cc: @manoj-dasari
There was a problem hiding this comment.
Will fix this in an upcoming PR. Creating a backlog WI to track.
|
@sowmya-sriram you have merge conflicts. |
@hsinghbisht-sfdc resolved merge conflicts, please take a look. |
References: Contributing guide · Skill authoring guide · Agent Skills spec
@W-22259678@
What changed
Why
Support widget rendition for CLTs
Notes
Skills
Manual checklist
Description quality
Instructions
Context efficiency
templates/,examples/, ordocs/subdirectoriesAutomated checks
Enforced by CI (
npm run validate:skills) per the Agent Skills spec:SKILL.mdnamematches directory name;descriptionis present, ≥ 20 words, ≤ 1024 characters, and includes trigger language