build(deps-dev): bump @playwright/test from 1.58.2 to 1.59.1#340
build(deps-dev): bump @playwright/test from 1.58.2 to 1.59.1#340dependabot[bot] wants to merge 3 commits intomainfrom
Conversation
|
@dependabot recreate |
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.58.2 to 1.59.1. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.58.2...v1.59.1) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-version: 1.59.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
f84ba5e to
5dd611e
Compare
node_modules/.bin/playwright is owned by @playwright/test, so npx playwright install was installing the wrong Chromium revision (for 1.58.2) while @vscode/test-web resolved playwright@1.59.1 from the root and expected a different Chromium build. Keep the two companion packages in sync to fix the binary mismatch that broke E2E Web tests.
E2E Test Results SummaryRun: 540 No test results found Searched for Specs With No ResultsThe following specs did not produce test results. This usually means the job crashed before tests ran (e.g. build failure, infra error, dependency download timeout).
ArtifactsView detailed test reports in the Artifacts section. |
E2E Test Results SummaryRun: 543 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. Some tests failed |
1 similar comment
E2E Test Results SummaryRun: 543 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. Some tests failed |
Blocked on upstream compatibilityThis PR's Web E2E failures are not a transient flake — they're a genuine compatibility regression between Playwright 1.59 and Root causeThe failing tests time out waiting for The test server logs show the files ARE served (
In Playwright 1.58.2 (current main), this race resolves and the tree populates. In Playwright 1.59.1's Chromium 147 (headless shell), the tree stays empty — reproduced locally. Why this isn't fixable in this PR
RecommendationClose this PR. Re-open when |
|
Closing — see #361 which adds a dependabot ignore entry for Playwright 1.59.x so this unmergeable bump stops getting reopened. Dependabot will offer the next Playwright version once @vscode/test-web@0.0.80 either bumps its own playwright pin or a new test-web release lands. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps @playwright/test from 1.58.2 to 1.59.1.
Release notes
Sourced from
@playwright/test's releases.... (truncated)
Commits
d466ac5chore: mark v1.59.1 (#40005)530e7e5cherry-pick(#4004): fix(cli): kill-all should kill dashboard9aa216ccherry-pick(#39994): Revert "fix(windows): hide console window when spawning ...01b2b15cherry-pick(#39980): chore: more release notes fixesa5cb6c9cherry-pick(#39972): chore: expose browser.bind and browser.unbind APIs99a17b5cherry-pick(#39975): chore: support opening .trace files via .link indirection43607c3cherry-pick(#39974): chore(webkit): update Safari user-agent version to 26.462cabe1cherry-pick(#39969): chore(npm): include all *.md from lib (#39970)0c65a75cherry-pick(#39968): chore: screencast.showActions apif04155bcherry-pick(#39958): chore: release notes for langs v1.59