Skip to content

ci: ignore Playwright 1.59.x in dependabot - W-22345718#361

Merged
kylewalke merged 4 commits intomainfrom
fix/dependabot-pin-playwright
May 4, 2026
Merged

ci: ignore Playwright 1.59.x in dependabot - W-22345718#361
kylewalke merged 4 commits intomainfrom
fix/dependabot-pin-playwright

Conversation

@kylewalke
Copy link
Copy Markdown
Contributor

@kylewalke kylewalke commented May 4, 2026

Summary

  • Add dependabot ignore entries for @playwright/test and playwright at the 1.59.x range
  • Prevents dependabot from reopening #340 (the same unmergeable PR) every week

Why

Playwright 1.59 breaks @vscode/test-web@0.0.80's fs-provider race under Chromium 147: the Explorer tree renders empty, so every Web E2E test times out waiting for .cls-ext-file-icon. Reproduced locally with playwright@1.59.1 + chromium_headless_shell-1217.

Upstream microsoft/vscode-test-web still pins playwright: ^1.58.2 and has not validated 1.59. Once they ship a 1.59-compatible release, remove these ignore entries so dependabot can bump both together.

Work item

@W-22345718@

Test plan

Playwright 1.59 breaks @vscode/test-web@0.0.80's fs-provider race
under Chromium 147: the Explorer tree renders empty, so every Web
E2E test times out waiting for .cls-ext-file-icon. Reproduced
locally with playwright@1.59.1 + chromium_headless_shell-1217.

Upstream microsoft/vscode-test-web still pins playwright@^1.58.2
and has not validated 1.59. Ignore 1.59.x bumps to stop dependabot
reopening the same unmergeable PR weekly. Remove these entries
once test-web ships a 1.59-compatible release.
@kylewalke kylewalke requested a review from a team as a code owner May 4, 2026 15:54
@kylewalke kylewalke requested a review from jonnyhork May 4, 2026 15:54
@kylewalke kylewalke changed the title ci: ignore Playwright 1.59.x in dependabot - W-22300000 ci: ignore Playwright 1.59.x in dependabot - W-22345718 May 4, 2026
Comment thread .claude/skills/pr-draft/SKILL.md Outdated
- Ignore plans/conversation history (may be stale)
- Write content per [concise/SKILL.md](../concise/SKILL.md)
- Include `@W-XXXXX@` in "What issues does this PR fix or reference?" per [.github/PULL_REQUEST_TEMPLATE.md](../../../.github/PULL_REQUEST_TEMPLATE.md):
- **REQUIRED:** Body MUST contain the WI wrapped in `@`s (e.g. `@W-22345718@` or `[@W-22345718@](url)`). `pr-validation` checks title AND body separately — title-only will fail CI with "PRs need to reference a GUS Work Item in both the PR title AND body." The bare `W-XXXXX` in the title does NOT satisfy the body check; the `@...@` wrapping is what the regex looks for. Include it in "What issues does this PR fix or reference?" per [.github/PULL_REQUEST_TEMPLATE.md](../../../.github/PULL_REQUEST_TEMPLATE.md):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want URIs to GUS in public repos

@kylewalke kylewalke merged commit 15b02d2 into main May 4, 2026
20 checks passed
@kylewalke kylewalke deleted the fix/dependabot-pin-playwright branch May 4, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants