fix describeOptions

Author: nikhil-mittal-165

packages/code-analyzer-apexguru-engine/src/engine.ts

@@ -54,6 +54,18 @@ export class ApexGuruEngine extends EngineEventEmitter implements Engine {
     async describeRules(describeOptions: DescribeOptions): Promise<RuleDescription[]> {
         this.emitDescribeRulesProgressEvent(0);
 
+        // Check if workspace has any Apex files (following SFGE pattern)
+        if (describeOptions.workspace) {
+            const workspaceFiles = await describeOptions.workspace.getWorkspaceFiles();
+            const hasApexFiles = workspaceFiles.some(file => this.isApexFile(path.basename(file)));
+
+            if (!hasApexFiles) {
+                this.emitLogEvent(LogLevel.Debug, 'No Apex files found in workspace. Returning no ApexGuru rules.');
+                this.emitDescribeRulesProgressEvent(100);
+                return [];
+            }
+        }
+
         // ApexGuru is dynamic - new rules can be added by Salesforce at any time.
         // We declare known rules explicitly (in apexguru-rules.ts), plus a fallback rule.
         // Unknown violations from the API will be mapped to "apexguru-other" by ViolationMapper.

packages/code-analyzer-apexguru-engine/test/ApexGuruEngine.test.ts

@@ -82,6 +82,66 @@ describe('ApexGuruEngine', () => {
             expect(progressSpy).toHaveBeenCalledWith(0);
             expect(progressSpy).toHaveBeenCalledWith(100);
         });
+
+        it('should return empty array when workspace has no Apex files', async () => {
+            mockWorkspace.getWorkspaceFiles = jest.fn().mockResolvedValue([
+                '/project/js/app.js',
+                '/project/js/utils.js',
+                '/project/css/styles.css'
+            ]);
+
+            const rules = await engine.describeRules({
+                logFolder: '/tmp/logs',
+                workingFolder: '/tmp/working',
+                workspace: mockWorkspace
+            });
+
+            expect(rules).toEqual([]);
+            expect(mockWorkspace.getWorkspaceFiles).toHaveBeenCalled();
+        });
+
+        it('should return all rules when workspace has Apex files', async () => {
+            mockWorkspace.getWorkspaceFiles = jest.fn().mockResolvedValue([
+                '/project/classes/Account.cls',
+                '/project/js/app.js'
+            ]);
+
+            const rules = await engine.describeRules({
+                logFolder: '/tmp/logs',
+                workingFolder: '/tmp/working',
+                workspace: mockWorkspace
+            });
+
+            expect(rules.length).toBeGreaterThan(0);
+            expect(rules.find(r => r.name === 'SoqlInALoop')).toBeDefined();
+        });
+
+        it('should return all rules when workspace has trigger files', async () => {
+            mockWorkspace.getWorkspaceFiles = jest.fn().mockResolvedValue([
+                '/project/triggers/AccountTrigger.trigger',
+                '/project/js/app.js'
+            ]);
+
+            const rules = await engine.describeRules({
+                logFolder: '/tmp/logs',
+                workingFolder: '/tmp/working',
+                workspace: mockWorkspace
+            });
+
+            expect(rules.length).toBeGreaterThan(0);
+            expect(rules.find(r => r.name === 'DmlInALoop')).toBeDefined();
+        });
+
+        it('should return all rules when no workspace provided', async () => {
+            const rules = await engine.describeRules({
+                logFolder: '/tmp/logs',
+                workingFolder: '/tmp/working'
+                // No workspace
+            });
+
+            expect(rules.length).toBeGreaterThan(0);
+            expect(rules.find(r => r.name === 'SoqlInALoop')).toBeDefined();
+        });
     });
 
     describe('runRules', () => {