CHANGE: @W-19015089@: Update dependencies as much as possible#315
Merged
Conversation
stephen-carter-at-sf
force-pushed
the
sc/W-19015089
branch
from
0192d09 to
5b6c4b7
Compare
jfeingold35
approved these changes
Jul 14, 2025
| "eslint": "^9.28.0", | ||
| "jest": "^29.7.0", | ||
| "@eslint/js": "^9.31.0", | ||
| "@types/jest": "^30.0.0", |
Contributor
There was a problem hiding this comment.
This is a dumb question, but why isn't @types/jest in the top-level package.json?
Contributor
Author
There was a problem hiding this comment.
The top level doesn't have any tests where we need the types defined. The top level package only needs jest so that we can call the jest script for the whole monorepo instead of calling jest individually on each package at a time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.