FIX: @W-19184117@: Our JSON schema fields primaryLocationIndex, locat…#319
Merged
Conversation
…ions, resources should not be marked as optional
jfeingold35
reviewed
Aug 1, 2025
| for (const tag of violationOutput.tags) { | ||
| tagsNode.node('tag').text(tag); | ||
| } | ||
| if (violationOutput.primaryLocationIndex != null) { |
Contributor
Author
There was a problem hiding this comment.
Removed unnecessary if statements
jfeingold35
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ions, resources should not be marked as optional.
Rationale:
We prefer to allow consumers of our json output to not have to check if the field exists, but instead to just check the size.
Since this does not currently reflect the truth that comes from the core data structure ( see https://github.com/forcedotcom/code-analyzer-core/blob/dev/packages/code-analyzer-core/src/results.ts#L43-L53) and the translation to JSON (see https://github.com/forcedotcom/code-analyzer-core/blob/dev/packages/code-analyzer-core/src/output-formats/results/json-run-results-format.ts#L136-L139)... we should fix this.