NEW @W-19212468@ Changed text when there are no violations#320
Merged
Conversation
randi274
reviewed
Aug 4, 2025
randi274
left a comment
randi274
left a comment
Contributor
There was a problem hiding this comment.
Looking good! I did find some additional occurrences of a similar pattern, but not seeing test failures - are these dead code paths or should they be updated as well?
Contributor
Author
|
@randi274 , I believe those cases are legitimate, since those are the cases for when a non-zero number of violations is found. It makes sense to say "Found 3 violations across 2 files." It doesn't make sense to say "Found 0 violations across 0 files". |
randi274
approved these changes
Aug 4, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.