chore: Fixup

Author: mkaufmann

jdbc-core/src/main/java/com/salesforce/datacloud/jdbc/protocol/async/AsyncQueryResultIterator.java

@@ -167,18 +167,9 @@ private CompletionStage<Optional<QueryResult>> pollForMoreChunks() {
                     return pollForMoreChunks();
                 }
             }
-            // Info stream ended, check if we're done
-            boolean queryIsDone = queryStatus != null
-                    && ((queryStatus.getCompletionStatus() == QueryStatus.CompletionStatus.FINISHED)
-                            || (queryStatus.getCompletionStatus() == QueryStatus.CompletionStatus.RESULTS_PRODUCED));
-            boolean allChunksConsumed =
-                    (queryStatus == null || nextChunk >= queryStatus.getChunkCount()) && (chunkIterator == null);
-
-            if (queryIsDone && allChunksConsumed) {
-                return CompletableFuture.completedFuture(Optional.empty());
-            }
 
-            // This should never happen
+            // This should never happen, callers of pollForMoreChunks should not call it when the query is already
+            // finished
             CompletableFuture<Optional<QueryResult>> future = new CompletableFuture<>();
             future.completeExceptionally(new RuntimeException("Unexpected end in next()"));
             return future;

jdbc-core/src/main/java/com/salesforce/datacloud/jdbc/protocol/async/core/AsyncStreamObserver.java

@@ -185,5 +185,7 @@ public void close() {
         if (stream != null) {
             stream.cancel("Call got closed by the client.", null);
         }
+        // We don't check if the pendingFuture is sethere intentionally. The close propagates through the gRPC layer
+        // and the pendingFuture will be completed with an error in the onError callback.
     }
 }