refactor: rename StreamingResultSet to DataCloudResultSet, drop marker interface

Pre-unify there were three result-set implementations: StreamingResultSet
(streaming Arrow query results), DataCloudMetadataResultSet (metadata),
SimpleResultSet (in-memory rows). The DataCloudResultSet interface — a
one-method (getQueryId) extension over java.sql.ResultSet — was the
common "implements" the public API surfaced; StreamingResultSet was the
only one that ever implemented it as a non-trivial impl.

The unify refactor collapsed all three implementations into
StreamingResultSet, but kept the interface and the "Streaming" name. Two
problems fall out:

- The "Streaming" name now lies. Metadata results flow through the same
  class but they're a one-shot in-memory IPC blob — nothing streaming
  about them. MetadataResultSets.of even passes /*queryId=*/ null
  because there is no query.
- The DataCloudResultSet interface has one implementer and one method.
  Layering an interface for one impl is just a reader trap: callers
  instinctively look for "what other implementations exist" and find
  none.

Collapse the two:
- Rename the class StreamingResultSet -> DataCloudResultSet.
- Delete the old DataCloudResultSet interface (the public method
  getQueryId() now lives directly on the class via @Getter).
- Update all production and test references; rename the affected test
  files to match (StreamingResultSet*Test -> DataCloudResultSet*Test).

The public API surface is unchanged in source for the common cases:
DataCloudConnection.getRowBasedResultSet / getChunkBasedResultSet still
return DataCloudResultSet, just as a class instead of an interface.
This is binary-incompatible for any caller that ever cast to or
implemented the old interface; in practice only StreamingResultSet
implemented it on the read side, and no code outside the driver
implemented it on the write side.

Author: mkaufmann

jdbc-core/src/main/java/com/salesforce/datacloud/jdbc/core/ArrowStreamReaderCursor.java

@@ -23,12 +23,12 @@
 import org.apache.arrow.vector.ipc.ArrowStreamReader;
 
 /**
- * Row cursor over an {@link ArrowStreamReader} that drives the {@link StreamingResultSet}.
+ * Row cursor over an {@link ArrowStreamReader} that drives the {@link DataCloudResultSet}.
  *
  * <p>The cursor owns the supplied {@link BufferAllocator} alongside the reader: closing the
  * cursor closes the reader (which releases ArrowBuf accounting) and then the allocator (which
  * returns its budget). This is the single place that guarantees root-allocator hygiene for the
- * driver; callers of {@link StreamingResultSet#of} hand ownership over and do not close the
+ * driver; callers of {@link DataCloudResultSet#of} hand ownership over and do not close the
  * allocator themselves.
  */
 @Slf4j

jdbc-core/src/main/java/com/salesforce/datacloud/jdbc/core/DataCloudConnection.java

@@ -221,7 +221,7 @@ public DataCloudResultSet getRowBasedResultSet(String queryId, long offset, long
                     QueryResultArrowStream.OUTPUT_FORMAT);
             val arrowStream = SQLExceptionQueryResultIterator.createSqlExceptionArrowStreamReader(
                     iterator, connectionProperties.isIncludeCustomerDetailInReason(), queryId, null);
-            return StreamingResultSet.of(arrowStream, queryId, ZoneId.systemDefault());
+            return DataCloudResultSet.of(arrowStream, queryId, ZoneId.systemDefault());
         } catch (StatusRuntimeException ex) {
             throw QueryExceptionHandler.createException(
                     connectionProperties.isIncludeCustomerDetailInReason(), null, queryId, ex);
@@ -264,7 +264,7 @@ public DataCloudResultSet getChunkBasedResultSet(String queryId, long chunkId, l
                     QueryResultArrowStream.OUTPUT_FORMAT);
             val arrowStream = SQLExceptionQueryResultIterator.createSqlExceptionArrowStreamReader(
                     iterator, connectionProperties.isIncludeCustomerDetailInReason(), queryId, null);
-            return StreamingResultSet.of(arrowStream, queryId, ZoneId.systemDefault());
+            return DataCloudResultSet.of(arrowStream, queryId, ZoneId.systemDefault());
         } catch (StatusRuntimeException ex) {
             throw QueryExceptionHandler.createException(
                     connectionProperties.isIncludeCustomerDetailInReason(), null, queryId, ex);