feat: support installation key for dependency graph queries @W-20525733@#886
Open
WillieRuemmele wants to merge 2 commits into
Open
feat: support installation key for dependency graph queries @W-20525733@#886WillieRuemmele wants to merge 2 commits into
WillieRuemmele wants to merge 2 commits into
Conversation
Thread installationKey through getDependencyGraph → PackageVersionDependency → SubscriberPackageVersion queries so that key-protected packages can have their dependencies displayed.
WillieRuemmele
force-pushed
the
wr/installKeyDisplayDeps
branch
from
749378d to
b6b169b
Compare
3 tasks
Cover the installation key feature across both code paths: - Flat graph: key appended to createFlatDependencyGraph query - Transitive graph: key appended to addSelectedNodeIds query - Negative case: no key when installationKey not provided - SOQL injection prevention: special characters escaped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installationKeyoption toPackageVersionDependencyOptionsand thread it throughPackage.getDependencyGraph→PackageVersionDependency→DependencyDotProducerAND InstallationKey = '...'toSubscriberPackageVersionqueries when a key is provided, enabling dependency resolution for key-protected packagesFixes forcedotcom/cli#3469
Work Item
@W-20525733@: Package Version Display Dependencies not possible, if installation key required
Proof of Work
Test plan
sf package version displaydependencies -p 04t<key-protected> -k <key> -v <hub>— should display the dependency graphsf package version displaydependencies -p 04t<non-protected>(no key) — should still work as beforesf package version displaydependencies -p 08c...— unaffected path, should work as before