fix: precise error messages for dist fallback (missing folder, missing file, empty file)

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: lesya7

src/resolve/adapters/webApplicationsSourceAdapter.ts

@@ -92,17 +92,23 @@ export class WebApplicationsSourceAdapter extends BundleSourceAdapter {
     const distPath = join(contentPath, 'dist');
     const indexPath = join(distPath, 'index.html');
 
-    const missingDistIndexMessage =
-      "If a webapplication.json file does not exist, you are required to include a 'dist/index.html' file. This will be the entry point for your web application.";
-
     if (!this.tree.exists(distPath) || !this.tree.isDirectory(distPath)) {
-      throw new SfError(missingDistIndexMessage, 'ExpectedSourceFilesError');
+      throw new SfError(
+        "When webapplication.json is not present, a 'dist' folder containing 'index.html' is required. The 'dist' folder was not found.",
+        'ExpectedSourceFilesError'
+      );
     }
     if (!this.tree.exists(indexPath)) {
-      throw new SfError(missingDistIndexMessage, 'ExpectedSourceFilesError');
+      throw new SfError(
+        "When webapplication.json is not present, a 'dist/index.html' file is required as the entry point. The file was not found.",
+        'ExpectedSourceFilesError'
+      );
     }
     if (this.tree.readFileSync(indexPath).length === 0) {
-      throw new SfError(missingDistIndexMessage, 'ExpectedSourceFilesError');
+      throw new SfError(
+        "When webapplication.json is not present, 'dist/index.html' must exist and be non-empty. The file was found but is empty.",
+        'ExpectedSourceFilesError'
+      );
     }
   }
 

test/resolve/adapters/webApplicationsSourceAdapter.test.ts

@@ -113,14 +113,15 @@ describe('WebApplicationsSourceAdapter', () => {
     expect(metadataAdapter.getComponent(META_FILE, false)).to.deep.equal(expected);
   });
 
-  const DIST_INDEX_MESSAGE =
-    "If a webapplication.json file does not exist, you are required to include a 'dist/index.html' file. This will be the entry point for your web application.";
-
   describe('without webapplication.json (dist fallback)', () => {
     it('should throw when the dist folder does not exist', () => {
       const t = VirtualTreeContainer.fromFilePaths([META_FILE, CONTENT_FILE]);
       const a = new WebApplicationsSourceAdapter(registry.types.webapplication, registryAccess, forceIgnore, t);
-      assert.throws(() => a.getComponent(APP_PATH), SfError, DIST_INDEX_MESSAGE);
+      assert.throws(
+        () => a.getComponent(APP_PATH),
+        SfError,
+        "When webapplication.json is not present, a 'dist' folder containing 'index.html' is required. The 'dist' folder was not found."
+      );
     });
 
     it('should throw when dist exists but index.html is missing', () => {
@@ -130,7 +131,11 @@ describe('WebApplicationsSourceAdapter', () => {
       ];
       const t = new VirtualTreeContainer(vfs);
       const a = new WebApplicationsSourceAdapter(registry.types.webapplication, registryAccess, forceIgnore, t);
-      assert.throws(() => a.getComponent(APP_PATH), SfError, DIST_INDEX_MESSAGE);
+      assert.throws(
+        () => a.getComponent(APP_PATH),
+        SfError,
+        "When webapplication.json is not present, a 'dist/index.html' file is required as the entry point. The file was not found."
+      );
     });
 
     it('should throw when dist/index.html is empty', () => {
@@ -140,7 +145,11 @@ describe('WebApplicationsSourceAdapter', () => {
       ];
       const t = new VirtualTreeContainer(vfs);
       const a = new WebApplicationsSourceAdapter(registry.types.webapplication, registryAccess, forceIgnore, t);
-      assert.throws(() => a.getComponent(APP_PATH), SfError, DIST_INDEX_MESSAGE);
+      assert.throws(
+        () => a.getComponent(APP_PATH),
+        SfError,
+        "When webapplication.json is not present, 'dist/index.html' must exist and be non-empty. The file was found but is empty."
+      );
     });
 
     it('should succeed when dist/index.html exists and is non-empty', () => {