fix: provide specific error messages for missing webapplication.json fields

lesya7 · cursoragent · lesya7 · commit 68843d78da07 · 2026-02-11T15:59:16.000-08:00
Address code review feedback: error messages now explicitly state which
required field is missing (outputDir, routing, routing.trailingSlash,
routing.fallback) instead of generic 'Expected source files' message.

Co-authored-by: Cursor &lt;cursoragent@cursor.com&gt;
diff --git a/src/resolve/adapters/webApplicationsSourceAdapter.ts b/src/resolve/adapters/webApplicationsSourceAdapter.ts
@@ -115,21 +115,30 @@ export class WebApplicationsSourceAdapter extends BundleSourceAdapter {
     }
 
     if (!config.outputDir || typeof config.outputDir !== 'string') {
-      this.expectedSourceError(descriptorPath);
+      throw new SfError(
+        "webapplication.json is missing required field 'outputDir'",
+        'InvalidWebApplicationConfigError'
+      );
     }
     const outputDirPath = join(contentPath, config.outputDir);
     if (!this.tree.exists(outputDirPath) || !this.tree.isDirectory(outputDirPath)) {
       this.expectedSourceError(outputDirPath);
     }
 
     if (!config.routing || typeof config.routing !== 'object') {
-      this.expectedSourceError(descriptorPath);
+      throw new SfError("webapplication.json is missing required field 'routing'", 'InvalidWebApplicationConfigError');
     }
     if (!config.routing.trailingSlash || typeof config.routing.trailingSlash !== 'string') {
-      this.expectedSourceError(descriptorPath);
+      throw new SfError(
+        "webapplication.json is missing required field 'routing.trailingSlash'",
+        'InvalidWebApplicationConfigError'
+      );
     }
     if (!config.routing.fallback || typeof config.routing.fallback !== 'string') {
-      this.expectedSourceError(descriptorPath);
+      throw new SfError(
+        "webapplication.json is missing required field 'routing.fallback'",
+        'InvalidWebApplicationConfigError'
+      );
     }
 
     const fallbackPath = join(outputDirPath, config.routing.fallback.replace(/^\//, ''));
diff --git a/test/resolve/adapters/webApplicationsSourceAdapter.test.ts b/test/resolve/adapters/webApplicationsSourceAdapter.test.ts
@@ -244,7 +244,7 @@ describe('WebApplicationsSourceAdapter', () => {
       assert.throws(
         () => a.getComponent(APP_PATH),
         SfError,
-        messages.getMessage('error_expected_source_files', [JSON_FILE, registry.types.webapplication.name])
+        "webapplication.json is missing required field 'outputDir'"
       );
     });
 
@@ -264,11 +264,7 @@ describe('WebApplicationsSourceAdapter', () => {
       const a = adapterWith({ outputDir: 'dist' }, [
         { dirPath: DIST_PATH, children: [{ name: 'index.html', data: Buffer.from('<html>test</html>') }] },
       ]);
-      assert.throws(
-        () => a.getComponent(APP_PATH),
-        SfError,
-        messages.getMessage('error_expected_source_files', [JSON_FILE, registry.types.webapplication.name])
-      );
+      assert.throws(() => a.getComponent(APP_PATH), SfError, "webapplication.json is missing required field 'routing'");
     });
 
     it('should throw when routing.fallback is missing', () => {
@@ -278,7 +274,7 @@ describe('WebApplicationsSourceAdapter', () => {
       assert.throws(
         () => a.getComponent(APP_PATH),
         SfError,
-        messages.getMessage('error_expected_source_files', [JSON_FILE, registry.types.webapplication.name])
+        "webapplication.json is missing required field 'routing.fallback'"
       );
     });
 
@@ -289,7 +285,7 @@ describe('WebApplicationsSourceAdapter', () => {
       assert.throws(
         () => a.getComponent(APP_PATH),
         SfError,
-        messages.getMessage('error_expected_source_files', [JSON_FILE, registry.types.webapplication.name])
+        "webapplication.json is missing required field 'routing.trailingSlash'"
       );
     });
 

Original file line number	Diff line number	Diff line change
`@@ -115,21 +115,30 @@ export class WebApplicationsSourceAdapter extends BundleSourceAdapter {`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`if (!config.outputDir \|\| typeof config.outputDir !== 'string') {`
`118`		`- this.expectedSourceError(descriptorPath);`
	`118`	`+ throw new SfError(`
	`119`	`+ "webapplication.json is missing required field 'outputDir'",`
	`120`	`+ 'InvalidWebApplicationConfigError'`
	`121`	`+ );`
`119`	`122`	`}`
`120`	`123`	`const outputDirPath = join(contentPath, config.outputDir);`
`121`	`124`	`if (!this.tree.exists(outputDirPath) \|\| !this.tree.isDirectory(outputDirPath)) {`
`122`	`125`	`this.expectedSourceError(outputDirPath);`
`123`	`126`	`}`
`124`	`127`
`125`	`128`	`if (!config.routing \|\| typeof config.routing !== 'object') {`
`126`		`- this.expectedSourceError(descriptorPath);`
	`129`	`+ throw new SfError("webapplication.json is missing required field 'routing'", 'InvalidWebApplicationConfigError');`
`127`	`130`	`}`
`128`	`131`	`if (!config.routing.trailingSlash \|\| typeof config.routing.trailingSlash !== 'string') {`
`129`		`- this.expectedSourceError(descriptorPath);`
	`132`	`+ throw new SfError(`
	`133`	`+ "webapplication.json is missing required field 'routing.trailingSlash'",`
	`134`	`+ 'InvalidWebApplicationConfigError'`
	`135`	`+ );`
`130`	`136`	`}`
`131`	`137`	`if (!config.routing.fallback \|\| typeof config.routing.fallback !== 'string') {`
`132`		`- this.expectedSourceError(descriptorPath);`
	`138`	`+ throw new SfError(`
	`139`	`+ "webapplication.json is missing required field 'routing.fallback'",`
	`140`	`+ 'InvalidWebApplicationConfigError'`
	`141`	`+ );`
`133`	`142`	`}`
`134`	`143`
`135`	`144`	`const fallbackPath = join(outputDirPath, config.routing.fallback.replace(/^\//, ''));`