fix: restrict yaml suffix resolution to externalServiceRegistrations directory @W-20424423@

src/registry/presets/decomposeExternalServiceRegistrationBeta.json

@@ -11,6 +11,7 @@
             "id": "yaml",
             "isAddressable": false,
             "name": "OAS Yaml Schema",
+            "strictDirectoryName": true,
             "suffix": "yaml",
             "xmlElementName": "schema"
           }

src/resolve/metadataResolver.ts

@@ -357,7 +357,7 @@ const resolveType =
       // It is likely that the metadata file is misspelled or has the wrong suffix.
       // A common occurrence is that a misspelled metadata file will fall back to
       // `EmailServicesFunction` because that is the default for the `.xml` suffix
-      if (resolvedType?.strictDirectoryName === true) {
+      if (resolvedType?.strictDirectoryName === true && !fsPath.split(sep).includes(resolvedType.directoryName)) {
         resolvedType = undefined;
       }
     }

test/resolve/metadataResolver.test.ts

@@ -22,12 +22,14 @@ import { createSandbox } from 'sinon';
 import {
   ComponentSet,
   MetadataResolver,
+  presetMap,
   registry,
   RegistryAccess,
   SourceComponent,
   VirtualDirectory,
   VirtualTreeContainer,
 } from '../../src';
+import { getEffectiveRegistry } from '../../src/registry/variants';
 import {
   bundle,
   decomposedtoplevel,
@@ -1044,4 +1046,30 @@ describe('MetadataResolver', () => {
       expect(components[0].name).to.equal('myComponent');
     });
   });
+
+  describe('decomposeExternalServiceRegistrationBeta preset', () => {
+    const esrRegistry = new RegistryAccess(
+      getEffectiveRegistry({ presets: [presetMap.get('decomposeExternalServiceRegistrationBeta')!] })
+    );
+
+    it('should not resolve a .yaml file outside externalServiceRegistrations as ExternalServiceRegistration', () => {
+      const yamlPath = join('force-app', 'main', 'default', 'customMetadata', 'stateTransition', 'transitions.yaml');
+      const tree = VirtualTreeContainer.fromFilePaths([yamlPath]);
+      const resolver = new MetadataResolver(esrRegistry, tree, false);
+
+      expect(() => resolver.getComponentsFromPath(yamlPath)).to.throw('Could not infer a metadata type');
+    });
+
+    it('should resolve a .yaml file inside externalServiceRegistrations as ExternalServiceRegistration', () => {
+      const esrDir = join('force-app', 'main', 'default', 'externalServiceRegistrations');
+      const yamlPath = join(esrDir, 'MyService.yaml');
+      const metaPath = join(esrDir, 'MyService.externalServiceRegistration-meta.xml');
+      const tree = VirtualTreeContainer.fromFilePaths([yamlPath, metaPath]);
+      const resolver = new MetadataResolver(esrRegistry, tree, false);
+
+      const components = resolver.getComponentsFromPath(yamlPath);
+      expect(components).to.have.lengthOf(1);
+      expect(components[0].type.name).to.equal('ExternalServiceRegistration');
+    });
+  });
 });