docs: clarify that --killSignal applies on start, not stop - #1151
Open
Hashim1999164 wants to merge 1 commit into
Open
docs: clarify that --killSignal applies on start, not stop#1151Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Document that --killSignal must be set when starting a process so later stop/restart use that signal. Passing it to forever stop has no effect. Fixes foreversd#1146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--helptext and README that--killSignalmust be passed toforever start(or when launching), where it is stored with the process.forever stop/restartuses that saved signal, and that passing--killSignaltoforever stophas no effect.Fixes #1146
Test plan
forever --helpand confirm the updated--killSignalwording appears