Skip to content

docs(framework): add SolidJSFramework component#614

Merged
nikohoffren merged 2 commits into
fork-commit-merge:mainfrom
zshaian:frameworks/solid
May 16, 2025
Merged

docs(framework): add SolidJSFramework component#614
nikohoffren merged 2 commits into
fork-commit-merge:mainfrom
zshaian:frameworks/solid

Conversation

@zshaian
Copy link
Copy Markdown
Contributor

@zshaian zshaian commented May 16, 2025

Pull Request Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes

  • Documentation content changes

[ ] Other... Please describe:

Does this introduce a breaking change?

[ ] Yes

  • No

Other information

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 16, 2025

@zshaian is attempting to deploy a commit to the Niko Hoffrén's Team Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fork-commit-merge-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 7:55pm

Copy link
Copy Markdown
Member

@nikohoffren nikohoffren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! You also have to add this component to these files similarly as other frameworks are added:

  • components/data/frameworkList.ts
  • pages/frameworks/[framework].tsx

That is because otherwise users cannot navigate to the SolidJS page from the frameworks dropdown from the header.

@nikohoffren
Copy link
Copy Markdown
Member

Looks good!

@nikohoffren nikohoffren merged commit eca0539 into fork-commit-merge:main May 16, 2025
5 checks passed
@nikohoffren
Copy link
Copy Markdown
Member

Pull request merged

This is an automated message from Fork, Commit, Merge - web [BOT].

Thank you for your contribution! Your pull request has been merged and your name has been added to the List of Contributors in README.md.
Please leave a star if you enjoyed working on this project.

What's next?

If you're looking for more ways to contribute, I invite you to check out my other projects here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants