docs(framework): add SolidJSFramework component#614
Conversation
|
@zshaian is attempting to deploy a commit to the Niko Hoffrén's Team Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nikohoffren
left a comment
There was a problem hiding this comment.
Hi! You also have to add this component to these files similarly as other frameworks are added:
- components/data/frameworkList.ts
- pages/frameworks/[framework].tsx
That is because otherwise users cannot navigate to the SolidJS page from the frameworks dropdown from the header.
|
Looks good! |
Pull request merged
Thank you for your contribution! Your pull request has been merged and your name has been added to the List of Contributors in README.md. What's next?If you're looking for more ways to contribute, I invite you to check out my other projects here. |
Pull Request Type
What kind of change does this PR introduce?
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:
Does this introduce a breaking change?
[ ] Yes
Other information