Skip to content

ScenarioFn uses common testing interface #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirockin wants to merge 21 commits into from
Closed

ScenarioFn uses common testing interface #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
2b8cb42
feat: export TF interface and make T compatible with it
Sep 3, 2024
f5e4195
chore: correct panic messages
Sep 3, 2024
0440c0e
docs: add comment
Sep 3, 2024
6348623
chore: replace t.Require with require
Sep 3, 2024
058f63a
chore: add Register
Sep 3, 2024
2e44253
chore: deprecate New()
Sep 3, 2024
f96ed7b
chore: remove unnecessary if/else
Sep 4, 2024
80a310b
docs: comment backward compatibility
Sep 4, 2024
c61040c
chore: remove require deprecation
Sep 4, 2024
771247a
fix: typo
Sep 4, 2024
499661a
chore: remove race condition
Sep 4, 2024
a8843cf
test: add new scenarios tests
Sep 4, 2024
0649f8b
feat: fix Error and Fatal general case
Sep 4, 2024
489bf95
Merge branch 'master' into sirockin-common-testing-interface
sirockin Sep 9, 2024
c77e68f
Merge branch 'master' into sirockin-common-testing-interface
sirockin Sep 10, 2024
2c85ff8
fix: lint errors
Sep 10, 2024
0e2b00a
fix: lint errors
Sep 10, 2024
b779d37
test: add tests for Register
Sep 10, 2024
3d88418
test: fix log test
Sep 10, 2024
026cc5d
test: use correct stage
Sep 10, 2024
0fc23db
Merge branch 'master' into sirockin-common-testing-interface
sirockin Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions benchcmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
)

func main() {
//nolint: staticcheck // we are testing the deprecated API
f1.New().
Add("emptyScenario", emptyScenario).
Add("failingScenario", failingScenario).
Expand Down
27 changes: 0 additions & 27 deletions internal/run/run_cmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,24 +835,11 @@ func TestOutput_JSONLogging(t *testing.T) {
"level": "info",
"scenario": "scenario_where_each_iteration_takes_200ms",
},
{

@sirockin sirockin Sep 10, 2024

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We remove these since the t.Logger() function is no longer available

"message": "logrus - setup",
"level": "info",
"logger": "logrus",
"scenario": "scenario_where_each_iteration_takes_200ms",
},

{
"message": "first iteration",
"level": "info",
"scenario": "scenario_where_each_iteration_takes_200ms",
},
{
"message": "logrus - first iteration",
"level": "info",
"logger": "logrus",
"scenario": "scenario_where_each_iteration_takes_200ms",
},
}

uiAndScenarioLogs := []logFieldMatchers{
Expand All @@ -866,25 +853,11 @@ func TestOutput_JSONLogging(t *testing.T) {
"level": "info",
"scenario": "scenario_where_each_iteration_takes_200ms",
},
{
"message": "logrus - setup",
"level": "info",
"logger": "logrus",
"scenario": "scenario_where_each_iteration_takes_200ms",
},

{
"message": "first iteration",
"level": "info",
"scenario": "scenario_where_each_iteration_takes_200ms",
},
{
"message": "logrus - first iteration",
"level": "info",
"logger": "logrus",
"scenario": "scenario_where_each_iteration_takes_200ms",
},

{
"message": "progress",
"level": "info",
Expand Down
Loading