feat(licenses): filter license choices to OSI approved options since question is for OSS projects

BREAKING CHANGE: the license prompt now only presents OSI approved options since the question is
only presented for OSS projects

Author: travi

src/prompts/license-choices-builder.js

@@ -0,0 +1,12 @@
+import spdxLicenseList from 'spdx-license-list';
+
+import {questionNames as coreQuestionNames} from './question-names.js';
+
+export default function buildLicenseChoices({[coreQuestionNames.VISIBILITY]: visibility}) {
+  if ('OSS' === visibility) {
+    return Object.entries(spdxLicenseList)
+      .filter(([, details]) => details.osiApproved)
+      .map(([identifier]) => identifier);
+  }
+  return [];
+}

src/prompts/license-choices-builder.test.js

@@ -0,0 +1,22 @@
+import spdxLicenseList from 'spdx-license-list';
+
+import {describe, it, expect} from 'vitest';
+import any from '@travi/any';
+
+import {questionNames as coreQuestionNames} from './question-names.js';
+import buildLicenseChoices from './license-choices-builder.js';
+
+describe('license choices builder', () => {
+  it('should filter the spdx license options to OSI approved licenses for OSS projects', async () => {
+    expect(buildLicenseChoices({[coreQuestionNames.VISIBILITY]: 'OSS'}))
+      .toEqual(Object.entries(spdxLicenseList).reduce((acc, [identifier, details]) => {
+        if (details.osiApproved) return [...acc, identifier];
+
+        return acc;
+      }, []));
+  });
+
+  it('should return an empty list for non-OSS projects', async () => {
+    expect(buildLicenseChoices(any.word())).toEqual([]);
+  });
+});

src/prompts/questions-test.js

@@ -1,15 +1,15 @@
 import path from 'path';
-import spdxLicenseList from 'spdx-license-list/simple';
 
 import any from '@travi/any';
 import {assert} from 'chai';
 import sinon from 'sinon';
 
 import {questionNames as coreQuestionNames} from './question-names.js';
 import * as predicates from './predicates.js';
-import {questionsForBaseDetails} from './questions.js';
 import {visibilityOptions} from './visibility-options.js';
 import * as optionsToChoicesMapper from './options-to-choices-mapper.js';
+import buildLicenseChoices from './license-choices-builder.js';
+import {questionsForBaseDetails} from './questions.js';
 
 suite('project scaffolder prompts', () => {
   let sandbox;
@@ -61,7 +61,7 @@ suite('project scaffolder prompts', () => {
             message: 'How should this this project be licensed (https://choosealicense.com/)?',
             type: 'list',
             when: predicates.licenseChoicesShouldBePresented,
-            choices: Array.from(spdxLicenseList),
+            choices: buildLicenseChoices,
             default: 'MIT'
           },
           {
@@ -113,7 +113,7 @@ suite('project scaffolder prompts', () => {
             message: 'How should this this project be licensed (https://choosealicense.com/)?',
             type: 'list',
             when: predicates.licenseChoicesShouldBePresented,
-            choices: Array.from(spdxLicenseList),
+            choices: buildLicenseChoices,
             default: 'MIT'
           },
           {

src/prompts/questions.js

@@ -1,6 +1,4 @@
 import {basename} from 'path';
-/* eslint-disable-next-line import/extensions -- needed for the esm bundle */
-import spdxLicenseList from 'spdx-license-list/simple.js';
 
 import {questionNames} from './question-names.js';
 import {
@@ -11,6 +9,7 @@ import {
 } from './predicates.js';
 import {visibilityOptions} from './visibility-options.js';
 import mapOptionsToChoices from './options-to-choices-mapper.js';
+import buildLicenseChoices from './license-choices-builder.js';
 
 function includeLicenseQuestions(copyrightHolder) {
   return [
@@ -26,7 +25,7 @@ function includeLicenseQuestions(copyrightHolder) {
       message: 'How should this this project be licensed (https://choosealicense.com/)?',
       type: 'list',
       when: licenseChoicesShouldBePresented,
-      choices: Array.from(spdxLicenseList),
+      choices: buildLicenseChoices,
       default: 'MIT'
     },
     {