fix(api): fix polling duration wrongfully marshalled (#1767)

Author: paul-nicolas

components/payments/cmd/connectors/internal/api/connector.go

@@ -13,7 +13,6 @@ import (
 	"github.com/formancehq/payments/internal/otel"
 	"github.com/formancehq/stack/libs/go-libs/api"
 	"github.com/formancehq/stack/libs/go-libs/bun/bunpaginate"
-	"github.com/formancehq/stack/libs/go-libs/logging"
 	"github.com/formancehq/stack/libs/go-libs/pointer"
 	"github.com/google/uuid"
 	"github.com/gorilla/mux"
@@ -132,24 +131,6 @@ func readConfig[Config models.ConnectorConfigObject](
 		caser := cases.Title(language.English)
 		m["provider"] = caser.String(connectorID.Provider.String())
 
-		// rewrite pollingDuration struct as a string to match API spec
-		pollingPeriod, ok := m["pollingPeriod"].(map[string]interface{})
-		if ok {
-			duration, found := pollingPeriod["duration"]
-			if found {
-				var ns int64
-				switch v := duration.(type) {
-				case int64:
-					ns = v
-				case float64:
-					ns = int64(v)
-				default:
-					logging.FromContext(ctx).Debugf("pollingPeriod.Duration was of an unexpected type: %T", v)
-				}
-				m["pollingPeriod"] = time.Duration(ns).String()
-			}
-		}
-
 		result, err := json.Marshal(m)
 		if err != nil {
 			otel.RecordError(span, err)

components/payments/cmd/connectors/internal/connectors/duration.go

@@ -10,7 +10,7 @@ type Duration struct {
 	time.Duration `json:"duration"`
 }
 
-func (d *Duration) MarshalJSON() ([]byte, error) {
+func (d Duration) MarshalJSON() ([]byte, error) {
 	return json.Marshal(d.Duration.String())
 }